From c4403681fc6e92583e7e60fb5fc4725044a3698e Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Fri, 2 Aug 2013 11:20:53 +0200 Subject: [PATCH] tor.cgi: Check for valid port numbers. --- doc/language_issues.de | 1 - doc/language_issues.en | 1 - doc/language_issues.es | 3 +++ doc/language_issues.fr | 3 +++ doc/language_issues.nl | 3 +++ doc/language_issues.pl | 3 +++ doc/language_issues.ru | 3 +++ doc/language_issues.tr | 3 +++ doc/language_missings | 8 ++++++++ html/cgi-bin/tor.cgi | 8 ++++++++ langs/de/cgi-bin/de.pl | 2 ++ langs/en/cgi-bin/en.pl | 2 ++ 12 files changed, 38 insertions(+), 2 deletions(-) diff --git a/doc/language_issues.de b/doc/language_issues.de index 6f76ef6467..8f23c51be3 100644 --- a/doc/language_issues.de +++ b/doc/language_issues.de @@ -486,7 +486,6 @@ WARNING: translation string unused: too long 80 char max WARNING: translation string unused: tor accounting period daily WARNING: translation string unused: tor accounting period monthly WARNING: translation string unused: tor accounting period weekly -WARNING: translation string unused: tor errmsg invalid relay name WARNING: translation string unused: tor exit country WARNING: translation string unused: traffic back WARNING: translation string unused: traffic calc time diff --git a/doc/language_issues.en b/doc/language_issues.en index 611041a777..9350208169 100644 --- a/doc/language_issues.en +++ b/doc/language_issues.en @@ -519,7 +519,6 @@ WARNING: translation string unused: tor accounting period monthly WARNING: translation string unused: tor accounting period weekly WARNING: translation string unused: tor bridge enabled WARNING: translation string unused: tor errmsg invalid node id -WARNING: translation string unused: tor errmsg invalid relay name WARNING: translation string unused: tor exit country WARNING: translation string unused: traffic back WARNING: translation string unused: traffic calc time diff --git a/doc/language_issues.es b/doc/language_issues.es index a09c507fde..68a04b7a30 100644 --- a/doc/language_issues.es +++ b/doc/language_issues.es @@ -828,6 +828,9 @@ WARNING: untranslated string: tor contact info WARNING: untranslated string: tor do not advertise relay WARNING: untranslated string: tor enabled WARNING: untranslated string: tor errmsg invalid ip or mask +WARNING: untranslated string: tor errmsg invalid relay name +WARNING: untranslated string: tor errmsg invalid relay port +WARNING: untranslated string: tor errmsg invalid socks port WARNING: untranslated string: tor exit country any WARNING: untranslated string: tor exit nodes WARNING: untranslated string: tor relay address diff --git a/doc/language_issues.fr b/doc/language_issues.fr index bcc871bc48..3fc2b778a7 100644 --- a/doc/language_issues.fr +++ b/doc/language_issues.fr @@ -819,6 +819,9 @@ WARNING: untranslated string: tor contact info WARNING: untranslated string: tor do not advertise relay WARNING: untranslated string: tor enabled WARNING: untranslated string: tor errmsg invalid ip or mask +WARNING: untranslated string: tor errmsg invalid relay name +WARNING: untranslated string: tor errmsg invalid relay port +WARNING: untranslated string: tor errmsg invalid socks port WARNING: untranslated string: tor exit country any WARNING: untranslated string: tor exit nodes WARNING: untranslated string: tor relay address diff --git a/doc/language_issues.nl b/doc/language_issues.nl index 5b44a0c6e9..492660453f 100644 --- a/doc/language_issues.nl +++ b/doc/language_issues.nl @@ -736,6 +736,9 @@ WARNING: untranslated string: tor contact info WARNING: untranslated string: tor do not advertise relay WARNING: untranslated string: tor enabled WARNING: untranslated string: tor errmsg invalid ip or mask +WARNING: untranslated string: tor errmsg invalid relay name +WARNING: untranslated string: tor errmsg invalid relay port +WARNING: untranslated string: tor errmsg invalid socks port WARNING: untranslated string: tor exit country any WARNING: untranslated string: tor exit nodes WARNING: untranslated string: tor relay address diff --git a/doc/language_issues.pl b/doc/language_issues.pl index a09c507fde..68a04b7a30 100644 --- a/doc/language_issues.pl +++ b/doc/language_issues.pl @@ -828,6 +828,9 @@ WARNING: untranslated string: tor contact info WARNING: untranslated string: tor do not advertise relay WARNING: untranslated string: tor enabled WARNING: untranslated string: tor errmsg invalid ip or mask +WARNING: untranslated string: tor errmsg invalid relay name +WARNING: untranslated string: tor errmsg invalid relay port +WARNING: untranslated string: tor errmsg invalid socks port WARNING: untranslated string: tor exit country any WARNING: untranslated string: tor exit nodes WARNING: untranslated string: tor relay address diff --git a/doc/language_issues.ru b/doc/language_issues.ru index 203d1b5e72..6481328a15 100644 --- a/doc/language_issues.ru +++ b/doc/language_issues.ru @@ -799,6 +799,9 @@ WARNING: untranslated string: tor contact info WARNING: untranslated string: tor do not advertise relay WARNING: untranslated string: tor enabled WARNING: untranslated string: tor errmsg invalid ip or mask +WARNING: untranslated string: tor errmsg invalid relay name +WARNING: untranslated string: tor errmsg invalid relay port +WARNING: untranslated string: tor errmsg invalid socks port WARNING: untranslated string: tor exit country any WARNING: untranslated string: tor exit nodes WARNING: untranslated string: tor relay address diff --git a/doc/language_issues.tr b/doc/language_issues.tr index e1fd016112..65ee683775 100644 --- a/doc/language_issues.tr +++ b/doc/language_issues.tr @@ -732,6 +732,9 @@ WARNING: untranslated string: tor contact info WARNING: untranslated string: tor do not advertise relay WARNING: untranslated string: tor enabled WARNING: untranslated string: tor errmsg invalid ip or mask +WARNING: untranslated string: tor errmsg invalid relay name +WARNING: untranslated string: tor errmsg invalid relay port +WARNING: untranslated string: tor errmsg invalid socks port WARNING: untranslated string: tor exit country any WARNING: untranslated string: tor exit nodes WARNING: untranslated string: tor relay address diff --git a/doc/language_missings b/doc/language_missings index 857b73b6b7..bbea66c8e1 100644 --- a/doc/language_missings +++ b/doc/language_missings @@ -351,6 +351,8 @@ < tor enabled < tor errmsg invalid ip or mask < tor errmsg invalid relay name +< tor errmsg invalid relay port +< tor errmsg invalid socks port < tor exit country < tor exit country any < tor exit nodes @@ -756,6 +758,8 @@ < tor enabled < tor errmsg invalid ip or mask < tor errmsg invalid relay name +< tor errmsg invalid relay port +< tor errmsg invalid socks port < tor exit country < tor exit country any < tor exit nodes @@ -1113,6 +1117,8 @@ < tor enabled < tor errmsg invalid ip or mask < tor errmsg invalid relay name +< tor errmsg invalid relay port +< tor errmsg invalid socks port < tor exit country < tor exit country any < tor exit nodes @@ -1475,6 +1481,8 @@ < tor enabled < tor errmsg invalid ip or mask < tor errmsg invalid relay name +< tor errmsg invalid relay port +< tor errmsg invalid socks port < tor exit country < tor exit country any < tor exit nodes diff --git a/html/cgi-bin/tor.cgi b/html/cgi-bin/tor.cgi index 14eac4e728..ed8964cdbd 100644 --- a/html/cgi-bin/tor.cgi +++ b/html/cgi-bin/tor.cgi @@ -101,6 +101,14 @@ if ($settings{'ACTION'} eq $Lang::tr{'save'}) { $errormessage = "$Lang::tr{'tor errmsg invalid relay name'}: $settings{'TOR_RELAY_NICKNAME'}"; } + if (!&General::validport($settings{'TOR_SOCKS_PORT'})) { + $errormessage = "$Lang::tr{'tor errmsg invalid socks port'}: $settings{'TOR_SOCKS_PORT'}"; + } + + if (!&General::validport($settings{'TOR_RELAY_PORT'})) { + $errormessage = "$Lang::tr{'tor errmsg invalid relay port'}: $settings{'TOR_RELAY_PORT'}"; + } + my @temp = split(/[\n,]/,$settings{'TOR_ALLOWED_SUBNETS'}); $settings{'TOR_ALLOWED_SUBNETS'} = ""; foreach (@temp) { diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl index 314441711d..9a97b8c769 100644 --- a/langs/de/cgi-bin/de.pl +++ b/langs/de/cgi-bin/de.pl @@ -1994,6 +1994,8 @@ 'tor enabled' => 'Tor einschalten', 'tor errmsg invalid ip or mask' => 'Ungültiges IP-Subnetz', 'tor errmsg invalid relay name' => 'Ungültiger Relay-Nickname.', +'tor errmsg invalid relay port' => 'Ungültiger Relay-Port', +'tor errmsg invalid socks port' => 'Ungültiger SOCKS-Port', 'tor exit country' => 'Exit-Land', 'tor exit country any' => 'Beliebig', 'tor exit nodes' => 'Exit-Nodes', diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl index 56119e96ae..8475850dff 100644 --- a/langs/en/cgi-bin/en.pl +++ b/langs/en/cgi-bin/en.pl @@ -2022,6 +2022,8 @@ 'tor errmsg invalid ip or mask' => 'Invalid IP subnet', 'tor errmsg invalid node id' => 'Invalid node ID', 'tor errmsg invalid relay name' => 'Invalid relay nickname', +'tor errmsg invalid relay port' => 'Invalid relay port', +'tor errmsg invalid socks port' => 'Invalid SOCKS port', 'tor exit country' => 'Exit country', 'tor exit country any' => 'Any country', 'tor exit nodes' => 'Exit Nodes', -- 2.39.5