From c449f506ef38435b2c7e9ceb661e48662ac86b10 Mon Sep 17 00:00:00 2001 From: Nathan Chancellor Date: Tue, 4 Mar 2025 14:19:21 +0100 Subject: [PATCH] drm/appletbdrm: Fix format specifier for size_t variables When building for a 32-bit platform, there are some warnings (or errors with CONFIG_WERROR=y) due to an incorrect specifier for 'size_t' variables, which is typedef'd as 'unsigned int' for these architectures: drivers/gpu/drm/tiny/appletbdrm.c:171:17: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat] 170 | drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n", | ~~~ | %zu 171 | actual_size, size); | ^~~~ ... drivers/gpu/drm/tiny/appletbdrm.c:212:17: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat] 211 | drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n", | ~~~ | %zu 212 | actual_size, size); | ^~~~ Use '%zu' as suggested, clearing up the warnings. Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs") Signed-off-by: Nathan Chancellor Reviewed-by: Jani Nikula Acked-by: Aditya Garg Link: https://patchwork.freedesktop.org/patch/msgid/20250304-appletbdrm-fix-size_t-specifier-v1-1-94fe1d2c91f8@kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/tiny/appletbdrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c index f5d177e234e43..394c8f9bd41ab 100644 --- a/drivers/gpu/drm/tiny/appletbdrm.c +++ b/drivers/gpu/drm/tiny/appletbdrm.c @@ -167,7 +167,7 @@ static int appletbdrm_send_request(struct appletbdrm_device *adev, } if (actual_size != size) { - drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n", + drm_err(drm, "Actual size (%d) doesn't match expected size (%zu)\n", actual_size, size); return -EIO; } @@ -208,7 +208,7 @@ retry: } if (actual_size != size) { - drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n", + drm_err(drm, "Actual size (%d) doesn't match expected size (%zu)\n", actual_size, size); return -EBADMSG; } -- 2.39.5