From c734f11bd8c2c57903cf186c1274891af61a17c8 Mon Sep 17 00:00:00 2001 From: Razvan Becheriu Date: Sat, 13 Sep 2025 08:47:24 +0300 Subject: [PATCH] [#3860] addressed review --- src/hooks/dhcp/radius/client_attribute.cc | 4 +++- src/hooks/dhcp/radius/data/dictionary | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/hooks/dhcp/radius/client_attribute.cc b/src/hooks/dhcp/radius/client_attribute.cc index 5e3b1118a1..4e33ee680a 100644 --- a/src/hooks/dhcp/radius/client_attribute.cc +++ b/src/hooks/dhcp/radius/client_attribute.cc @@ -301,7 +301,9 @@ AttrString::toBytes() const { output.resize(2 + getValueLen()); output[0] = getType(); output[1] = 2 + getValueLen(); - memmove(&output[2], &value_[0], output.size() - 2); + if (output.size() > 2) { + memmove(&output[2], &value_[0], output.size() - 2); + } return (output); } diff --git a/src/hooks/dhcp/radius/data/dictionary b/src/hooks/dhcp/radius/data/dictionary index 94ed4716bc..f81920b106 100644 --- a/src/hooks/dhcp/radius/data/dictionary +++ b/src/hooks/dhcp/radius/data/dictionary @@ -257,3 +257,7 @@ VALUE Acct-Terminate-Cause Host-Request 18 #$INCLUDE foobar #VENDOR DSL-Forum 3561 +#BEGIN-VENDOR DSL-Forum +#ATTRIBUTE Agent-Circuit-Id 1 string +#END-VENDOR DSL-Forum + -- 2.47.3