From c88fc0c3d056ee1eeb3ac82caf11a3779b85349a Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Mon, 29 Nov 2021 15:30:10 +0100 Subject: [PATCH] hwclock: don't ignore sscanf() return code [coverity scan] Signed-off-by: Karel Zak --- sys-utils/hwclock.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c index ff148f62ac..af8ac0860c 100644 --- a/sys-utils/hwclock.c +++ b/sys-utils/hwclock.c @@ -251,15 +251,17 @@ static int read_adjtime(const struct hwclock_control *ctl, fclose(adjfile); - sscanf(line1, "%lf %"SCNd64" %lf", - &adjtime_p->drift_factor, - &last_adj_time, - &adjtime_p->not_adjusted); + if (sscanf(line1, "%lf %"SCNd64" %lf", + &adjtime_p->drift_factor, + &last_adj_time, + &adjtime_p->not_adjusted) != 3) + warnx(_("Warning: unrecognized line in adjtime file: %s"), line1); - sscanf(line2, "%"SCNd64, &last_calib_time); + if (sscanf(line2, "%"SCNd64, &last_calib_time) != 1) + warnx(_("Warning: unrecognized line in adjtime file: %s"), line2); - adjtime_p->last_adj_time = (time_t)last_adj_time; - adjtime_p->last_calib_time = (time_t)last_calib_time; + adjtime_p->last_adj_time = (time_t)last_adj_time; + adjtime_p->last_calib_time = (time_t)last_calib_time; if (!strcmp(line3, "UTC\n")) { adjtime_p->local_utc = UTC; -- 2.47.3