From cb3677cd50dcb07e74d0113337e40e9e3e14d728 Mon Sep 17 00:00:00 2001 From: Li Qiang Date: Mon, 22 Aug 2016 13:11:57 +0530 Subject: [PATCH] net: vmxnet: use g_new for pkt initialisation When vmxnet transport abstraction layer initialises pkt, the maximum fragmentation count is not checked. This could lead to an integer overflow causing a NULL pointer dereference. Replace g_malloc() with g_new() to catch the multiplication overflow. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit Acked-by: Dmitry Fleytman Signed-off-by: Michael Roth --- hw/net/vmxnet_tx_pkt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/net/vmxnet_tx_pkt.c b/hw/net/vmxnet_tx_pkt.c index 5ba2f5ea6c7..849826b15e2 100644 --- a/hw/net/vmxnet_tx_pkt.c +++ b/hw/net/vmxnet_tx_pkt.c @@ -60,10 +60,9 @@ void vmxnet_tx_pkt_init(struct VmxnetTxPkt **pkt, uint32_t max_frags, { struct VmxnetTxPkt *p = g_malloc0(sizeof *p); - p->vec = g_malloc((sizeof *p->vec) * - (max_frags + VMXNET_TX_PKT_PL_START_FRAG)); + p->vec = g_new(struct iovec, max_frags + VMXNET_TX_PKT_PL_START_FRAG); - p->raw = g_malloc((sizeof *p->raw) * max_frags); + p->raw = g_new(struct iovec, max_frags); p->max_payload_frags = max_frags; p->max_raw_frags = max_frags; -- 2.39.5