From cb76ad42cb3aa0b10e8d4d01b347c95a0bdad0ba Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Wed, 27 Aug 2014 09:14:16 -0400 Subject: [PATCH] qemu_driver: Resolve Coverity CONSTANT_EXPRESSION_RESULT The call to virDomainSnapshotRedefinePrep() had a spurrious ! in front of it which caused Coverity to complan that the expression is always false. (cherry picked from commit 9d7254de430f7ef7a4c6a2a20718942369ce9d06) --- src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 10c6fe6f36..545975885b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13457,8 +13457,8 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain, } if (redefine) { - if (!virDomainSnapshotRedefinePrep(domain, vm, &def, &snap, - &update_current, flags) < 0) + if (virDomainSnapshotRedefinePrep(domain, vm, &def, &snap, + &update_current, flags) < 0) goto cleanup; } else { /* Easiest way to clone inactive portion of vm->def is via -- 2.47.3