From cd1d97ee04364e314fea9b66d84f7491a3d37044 Mon Sep 17 00:00:00 2001 From: Razvan Becheriu Date: Mon, 8 Sep 2025 21:50:29 +0300 Subject: [PATCH] [#3213] addressed review comments --- ChangeLog | 6 ++++++ doc/sphinx/arm/stats.rst | 10 +--------- src/share/api/statistic-get-all.json | 2 +- src/share/api/statistic-global-get-all.json | 2 +- 4 files changed, 9 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index f7ed25a58e..9d79562ec3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2394. [func] razvan + Added new 'statistic-global-get-all' command for kea-dhcp4 + and kea-dhcp6 servers, which returns all statistica except + subnet counters. + (Gitlab #3213) + 2393. [func] razvan Added global counters for 'assigned-addresses', 'assigned-nas' and 'assigned-pds'. The 'stat-lease4-get' diff --git a/doc/sphinx/arm/stats.rst b/doc/sphinx/arm/stats.rst index 4e85c18889..74236c51bd 100644 --- a/doc/sphinx/arm/stats.rst +++ b/doc/sphinx/arm/stats.rst @@ -219,10 +219,6 @@ example command may look like this: "arguments": { } } -The server responds with details of all recorded statistics, with a -result set to 0 to indicate that it iterated over all statistics (even -when the total number of statistics is zero). - Here is an example response returning all collected statistics: :: @@ -935,7 +931,7 @@ The ``statistic-global-get-all`` Command ---------------------------------------- The :isccmd:`statistic-global-get-all` command retrieves all global statistics recorded -(same as :isccmd:`statistic-global-get-all` but omitting subnet statistics). An example +(same as :isccmd:`statistic-get-all` but omitting subnet statistics). An example command may look like this: :: @@ -945,10 +941,6 @@ command may look like this: "arguments": { } } -The server responds with details of all recorded statistics, with a -result set to 0 to indicate that it iterated over all statistics (even -when the total number of statistics is zero). - Here is an example response returning all collected statistics: :: diff --git a/src/share/api/statistic-get-all.json b/src/share/api/statistic-get-all.json index 74a30433b6..23f4b58363 100644 --- a/src/share/api/statistic-get-all.json +++ b/src/share/api/statistic-get-all.json @@ -5,7 +5,7 @@ "This command retrieves all recorded statistics." ], "cmd-comment": [ - "The server responds with the details of all recorded statistics, with a result of 0 indicating that it iterated over all statistics (even when the total number of statistics is zero)." + "The server responds with the details of all recorded statistics." ], "cmd-syntax": [ "{", diff --git a/src/share/api/statistic-global-get-all.json b/src/share/api/statistic-global-get-all.json index e007da5200..bdcbe09b27 100644 --- a/src/share/api/statistic-global-get-all.json +++ b/src/share/api/statistic-global-get-all.json @@ -5,7 +5,7 @@ "This command retrieves all recorded global statistics (omitting subnet statistics)." ], "cmd-comment": [ - "The server responds with the details of all recorded global statistics (omitting subnet statistics), with a result of 0 indicating that it iterated over all global statistics (even when the total number of global statistics is zero)." + "The server responds with the details of all recorded global statistics (omitting subnet statistics)." ], "cmd-syntax": [ "{", -- 2.47.3