From cebb7fea7cf10b347b8a76448788779ad32e63f8 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Wed, 7 Mar 2018 14:02:38 +0100 Subject: [PATCH] memory: fix flatview_access_valid RCU read lock/unlock imbalance Fixes: 11e732a5ed46903f997985bed4c3767ca28a7eb6 Reported-by: Cornelia Huck Reported-by: luigi burdo Signed-off-by: Paolo Bonzini Tested-by: Cornelia Huck Tested-by: Thomas Huth Message-id: 20180307130238.19358-1-pbonzini@redhat.com Signed-off-by: Peter Maydell (cherry picked from commit b39b61e410022f96ceb53d4381d25cba5126ac44) Signed-off-by: Michael Roth --- exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/exec.c b/exec.c index d589283bdd8..5f8017a5d72 100644 --- a/exec.c +++ b/exec.c @@ -3320,7 +3320,6 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len, if (!memory_access_is_direct(mr, is_write)) { l = memory_access_size(mr, l, addr); if (!memory_region_access_valid(mr, xlat, l, is_write)) { - rcu_read_unlock(); return false; } } -- 2.39.5