From d0355b8a2c7dcb3db2e244fafdaa4bd02794347e Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Tue, 25 Jul 2023 12:01:33 +0000 Subject: [PATCH] libpakfire: digest: Use better return codes Signed-off-by: Michael Tremer --- src/libpakfire/digest.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/libpakfire/digest.c b/src/libpakfire/digest.c index 3cd5717ea..7149c27ba 100644 --- a/src/libpakfire/digest.c +++ b/src/libpakfire/digest.c @@ -228,9 +228,7 @@ static int pakfire_digests_check_length(struct pakfire* pakfire, // Otherwise set an error ERROR(pakfire, "Digest is of an unexpected length\n"); - errno = ENOMSG; - - return 1; + return -ENOMSG; } static EVP_MD_CTX* __pakfire_digest_setup(struct pakfire* pakfire, const EVP_MD* md) { @@ -479,10 +477,8 @@ int pakfire_digests_compare(struct pakfire* pakfire, const struct pakfire_digest int r; // Check if we are at least comparing one type - if (!types) { - errno = EINVAL; - return 1; - } + if (!types) + return -EINVAL; // Check SHA-3-512 if (types & PAKFIRE_DIGEST_SHA3_512) { -- 2.39.5