From d310b0869753a860e499c66823fb4fe427d46af8 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 26 Nov 2019 15:13:57 +0100 Subject: [PATCH] qemu: blockjob: Finish handling job with broken data Now that we have a separate job type which will not trigger normal code paths for terminating job we can remove the ad-hoc handling. This possibly fixes the issue of a broken job inheriting the disk and then finishing in which case we'd not detach the backing chain. Signed-off-by: Peter Krempa Reviewed-by: Cole Robinson --- src/qemu/qemu_blockjob.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index 1e31052385..baa79ea80c 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -1335,11 +1335,6 @@ qemuBlockJobEventProcessConcluded(qemuBlockJobDataPtr job, if (qemuDomainObjExitMonitor(driver, vm) < 0) goto cleanup; - if (job->invalidData) { - VIR_WARN("terminating job '%s' with invalid data", job->name); - goto cleanup; - } - if ((job->newstate == QEMU_BLOCKJOB_STATE_COMPLETED || job->newstate == QEMU_BLOCKJOB_STATE_FAILED) && job->state == QEMU_BLOCKJOB_STATE_ABORTING) -- 2.47.3