From d382c765d083ad871b4a053059351edd348a2442 Mon Sep 17 00:00:00 2001 From: Bartosz Golaszewski Date: Sat, 6 Dec 2025 12:53:55 +0100 Subject: [PATCH] gpio: shared: fix auxiliary device cleanup order Dropping the last reference to the internal struct device should be the last thing we do so delete the device first and then uninit it which also involves the final put_device(). Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support") Link: https://lore.kernel.org/r/20251206-gpio-shared-teardown-fixes-v1-3-35ac458cfce1@oss.qualcomm.com Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpiolib-shared.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c index 4084a28a953a..2d3b0c3460e5 100644 --- a/drivers/gpio/gpiolib-shared.c +++ b/drivers/gpio/gpiolib-shared.c @@ -415,8 +415,8 @@ static void gpio_shared_remove_adev(struct auxiliary_device *adev) { lockdep_assert_held(&gpio_shared_lock); - auxiliary_device_uninit(adev); auxiliary_device_delete(adev); + auxiliary_device_uninit(adev); } int gpio_device_setup_shared(struct gpio_device *gdev) -- 2.47.3