From d5d1507b347b7cd6c3b82459b96f1889b29939ef Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Sat, 25 Jan 2014 18:18:23 +0100 Subject: [PATCH] readline: Add missing GCC_FMT_ATTR This fixes a compiler warning with -Werror=missing-format-attribute and allows improved compiler checks for variable argument lists. Signed-off-by: Stefan Weil Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- include/qemu/readline.h | 3 ++- monitor.c | 3 ++- qemu-io.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/include/qemu/readline.h b/include/qemu/readline.h index a89fe4a9a96..49efe4e39b4 100644 --- a/include/qemu/readline.h +++ b/include/qemu/readline.h @@ -5,7 +5,8 @@ #define READLINE_MAX_CMDS 64 #define READLINE_MAX_COMPLETIONS 256 -typedef void ReadLinePrintfFunc(void *opaque, const char *fmt, ...); +typedef void GCC_FMT_ATTR(2, 3) ReadLinePrintfFunc(void *opaque, + const char *fmt, ...); typedef void ReadLineFlushFunc(void *opaque); typedef void ReadLineFunc(void *opaque, const char *str, void *readline_opaque); diff --git a/monitor.c b/monitor.c index 80456fbe5b0..5ba541dc6f1 100644 --- a/monitor.c +++ b/monitor.c @@ -4888,7 +4888,8 @@ static void sortcmdlist(void) /* These functions just adapt the readline interface in a typesafe way. We * could cast function pointers but that discards compiler checks. */ -static void monitor_readline_printf(void *opaque, const char *fmt, ...) +static void GCC_FMT_ATTR(2, 3) monitor_readline_printf(void *opaque, + const char *fmt, ...) { va_list ap; va_start(ap, fmt); diff --git a/qemu-io.c b/qemu-io.c index d6690289b82..7f459d8ffe4 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -219,7 +219,8 @@ static char *get_prompt(void) return prompt; } -static void readline_printf_func(void *opaque, const char *fmt, ...) +static void GCC_FMT_ATTR(2, 3) readline_printf_func(void *opaque, + const char *fmt, ...) { va_list ap; va_start(ap, fmt); -- 2.39.5