From d5ef04441eb1de3efc27aa70193fe3d7f0b5c408 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Wed, 11 Jun 2025 13:12:56 +0200 Subject: [PATCH] netlink: Fix for potential crash parsing a flowtable Kernel's flowtable message might not contain the NFTA_FLOWTABLE_HOOK_DEVS attribute. In that case, nftnl_flowtable_get() will return NULL for the respective nftnl attribute. Fixes: db0697ce7f602 ("src: support for flowtable listing") Signed-off-by: Phil Sutter Reviewed-by: Pablo Neira Ayuso --- src/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/netlink.c b/src/netlink.c index bed816af..0e0d32b8 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -1847,7 +1847,7 @@ netlink_delinearize_flowtable(struct netlink_ctx *ctx, if (nftnl_flowtable_is_set(nlo, NFTNL_FLOWTABLE_FLAGS)) flowtable->flags = nftnl_flowtable_get_u32(nlo, NFTNL_FLOWTABLE_FLAGS); dev_array = nftnl_flowtable_get(nlo, NFTNL_FLOWTABLE_DEVICES); - while (dev_array[len]) + while (dev_array && dev_array[len]) len++; if (len) -- 2.47.2