From d7869160156df64fc381a763b4a30c865f947ece Mon Sep 17 00:00:00 2001 From: Greg Stark Date: Wed, 17 Feb 2010 11:35:51 +0000 Subject: [PATCH] revert prior patch to fsync directories until portability problems exposed by build farm can be sorted out --- src/port/copydir.c | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/src/port/copydir.c b/src/port/copydir.c index bd252691812..067f2bc9103 100644 --- a/src/port/copydir.c +++ b/src/port/copydir.c @@ -11,7 +11,7 @@ * as a service. * * IDENTIFICATION - * $PostgreSQL: pgsql/src/port/copydir.c,v 1.16.2.2 2010/02/14 17:50:34 stark Exp $ + * $PostgreSQL: pgsql/src/port/copydir.c,v 1.16.2.3 2010/02/17 11:35:51 stark Exp $ * *------------------------------------------------------------------------- */ @@ -50,7 +50,6 @@ copydir(char *fromdir, char *todir, bool recurse) { DIR *xldir; struct dirent *xlde; - int dirfd; char fromfile[MAXPGPATH]; char tofile[MAXPGPATH]; @@ -92,26 +91,6 @@ copydir(char *fromdir, char *todir, bool recurse) } FreeDir(xldir); - - /* - * fsync the directory to make sure not just the data but also the - * new directory file entries have reached the disk. While needed - * by most filesystems, the window got bigger with newer ones like - * ext4. - */ - dirfd = BasicOpenFile(todir, - O_RDONLY | PG_BINARY, - S_IRUSR | S_IWUSR); - if(dirfd == -1) - ereport(ERROR, - (errcode_for_file_access(), - errmsg("could not open directory for fsync \"%s\": %m", todir))); - - if(pg_fsync(dirfd) == -1) - ereport(ERROR, - (errcode_for_file_access(), - errmsg("could not fsync directory \"%s\": %m", todir))); - close(dirfd); } /* -- 2.39.5