From d83c99fa93d88e4e98e0147943cbfa4739099323 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sat, 8 Nov 2025 19:50:18 -0500 Subject: [PATCH] Use map for getAppliedPolicyTypeAsString Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contrib/ProtobufLogger.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/contrib/ProtobufLogger.py b/contrib/ProtobufLogger.py index 1fea0a1cf3..23586d5aed 100644 --- a/contrib/ProtobufLogger.py +++ b/contrib/ProtobufLogger.py @@ -38,6 +38,15 @@ class PDNSPBConnHandler(object): self._oturl = oturl self._printjson = printjson + messageTypeToStringMap = { + dnsmessage_pb2.PBDNSMessage.UNKNOWN: 'Unknown', + dnsmessage_pb2.PBDNSMessage.QNAME: 'QName', + dnsmessage_pb2.PBDNSMessage.CLIENTIP: 'Client IP', + dnsmessage_pb2.PBDNSMessage.RESPONSEIP: 'Response IP', + dnsmessage_pb2.PBDNSMessage.NSDNAME: 'NS DName', + dnsmessage_pb2.PBDNSMessage.NSIP: 'NS IP', + } + def run(self): while True: data = self._conn.recv(2) @@ -150,18 +159,8 @@ class PDNSPBConnHandler(object): @staticmethod def getAppliedPolicyTypeAsString(polType): - if polType == dnsmessage_pb2.PBDNSMessage.UNKNOWN: - return 'Unknown' - elif polType == dnsmessage_pb2.PBDNSMessage.QNAME: - return 'QName' - elif polType == dnsmessage_pb2.PBDNSMessage.CLIENTIP: - return 'Client IP' - elif polType == dnsmessage_pb2.PBDNSMessage.RESPONSEIP: - return 'Response IP' - elif polType == dnsmessage_pb2.PBDNSMessage.NSDNAME: - return 'NS DName' - elif polType == dnsmessage_pb2.PBDNSMessage.NSIP: - return 'NS IP' + try: + return messageTypeToStringMap.get(polType, "Unrecognized") @staticmethod def getEventAsString(event): -- 2.47.3