From d8f09900091062c3af4ba35c954729101c1b65ba Mon Sep 17 00:00:00 2001
From: Tomas Krizek <tomas.krizek@nic.cz>
Date: Wed, 14 Nov 2018 12:46:32 +0100
Subject: [PATCH] pytests: import test_long_lived (test2)

---
 tests/pytests/kresd.py           | 17 +++++------------
 tests/pytests/test_conn_mgmt.py  | 17 +++++++++++++++++
 tests/pytests/test_tcp_prefix.py |  7 +------
 tests/pytests/utils.py           | 12 ++++++++++++
 4 files changed, 35 insertions(+), 18 deletions(-)

diff --git a/tests/pytests/kresd.py b/tests/pytests/kresd.py
index 0ef25661e..0f9e174c6 100644
--- a/tests/pytests/kresd.py
+++ b/tests/pytests/kresd.py
@@ -41,13 +41,6 @@ def make_ssl_context():
     return context
 
 
-def ping_alive(sock):
-    buff, msgid = utils.get_msgbuff()
-    sock.sendall(buff)
-    answer = utils.receive_parse_answer(sock)
-    return answer.id == msgid
-
-
 class Kresd(ContextDecorator):
     def __init__(self, workdir, port, tls_port, ip=None, ip6=None):
         if ip is None and ip6 is None:
@@ -110,11 +103,11 @@ class Kresd(ContextDecorator):
     def all_ports_alive(self):
         alive = True
         if self.ip:
-            alive &= ping_alive(self.ip_tcp_socket())
-            alive &= ping_alive(self.ip_tls_socket())
+            alive &= utils.ping_alive(self.ip_tcp_socket())
+            alive &= utils.ping_alive(self.ip_tls_socket())
         if self.ip6:
-            alive &= ping_alive(self.ip6_tcp_socket())
-            alive &= ping_alive(self.ip6_tls_socket())
+            alive &= utils.ping_alive(self.ip6_tcp_socket())
+            alive &= utils.ping_alive(self.ip6_tls_socket())
         return alive
 
     def _wait_for_tcp_port(self, delay=0.1, max_attempts=20):
@@ -127,7 +120,7 @@ class Kresd(ContextDecorator):
                 time.sleep(delay)
                 continue
             else:
-                return ping_alive(sock)
+                return utils.ping_alive(sock)
             finally:
                 sock.close()
         raise RuntimeError("Kresd didn't start in time")
diff --git a/tests/pytests/test_conn_mgmt.py b/tests/pytests/test_conn_mgmt.py
index d7c335dca..2f884be54 100644
--- a/tests/pytests/test_conn_mgmt.py
+++ b/tests/pytests/test_conn_mgmt.py
@@ -1,5 +1,7 @@
 """TCP Connection Management tests"""
 
+import time
+
 import utils
 
 
@@ -34,3 +36,18 @@ def test_pipelining(kresd_sock):
 
     msg_answer = utils.receive_parse_answer(kresd_sock)
     assert msg_answer.id == msgid1
+
+
+def test_long_lived(kresd_sock):
+    """
+    Test establishes a TCP connection a sends several queries over it. They are sent
+    seqeuntially, each with a delay, which in total exceeds maximum timeout.
+
+    Expected: kresd must not close the connection
+    """
+    utils.ping_alive(kresd_sock)
+    end_time = time.time() + utils.MAX_TIMEOUT
+
+    while time.time() < end_time:
+        time.sleep(3)
+        utils.ping_alive(kresd_sock)
diff --git a/tests/pytests/test_tcp_prefix.py b/tests/pytests/test_tcp_prefix.py
index d61132093..3b1e33e69 100644
--- a/tests/pytests/test_tcp_prefix.py
+++ b/tests/pytests/test_tcp_prefix.py
@@ -21,11 +21,6 @@ import pytest
 import utils
 
 
-# default net.tcp_in_idle is 10s, TCP_DEFER_ACCEPT 3s, some extra for
-# Python handling / edge cases
-MAX_TIMEOUT = 16
-
-
 def send_incorrect_repeatedly(sock, buff, delay=1):
     """Utility function to keep sending the buffer until MAX_TIMEOUT is reached.
 
@@ -34,7 +29,7 @@ def send_incorrect_repeatedly(sock, buff, delay=1):
 
     If the connection remains open, test is failed.
     """
-    end_time = time.time() + MAX_TIMEOUT
+    end_time = time.time() + utils.MAX_TIMEOUT
 
     with pytest.raises(BrokenPipeError, message="kresd didn't close connection"):
         while time.time() < end_time:
diff --git a/tests/pytests/utils.py b/tests/pytests/utils.py
index 9f365d8e4..55cc819c2 100644
--- a/tests/pytests/utils.py
+++ b/tests/pytests/utils.py
@@ -5,6 +5,11 @@ import dns
 import dns.message
 
 
+# default net.tcp_in_idle is 10s, TCP_DEFER_ACCEPT 3s, some extra for
+# Python handling / edge cases
+MAX_TIMEOUT = 16
+
+
 def receive_answer(sock):
     answer_total_len = 0
     data = sock.recv(2)
@@ -67,3 +72,10 @@ def get_garbage(length):
 def get_prefixed_garbage(length):
     data = get_garbage(length)
     return prepare_buffer(data)
+
+
+def ping_alive(sock):
+    buff, msgid = get_msgbuff()
+    sock.sendall(buff)
+    answer = receive_parse_answer(sock)
+    return answer.id == msgid
-- 
2.47.3