From d985ce5ae91b5749b629ad24a028249bfbd76372 Mon Sep 17 00:00:00 2001
From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 22 Jan 2019 11:26:32 +0000
Subject: [PATCH] ipsec-interfaces: Move conditional block into the loop

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---
 src/scripts/ipsec-interfaces | 38 ++++++++++++++++++------------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/src/scripts/ipsec-interfaces b/src/scripts/ipsec-interfaces
index d73eef9b08..c137a77b99 100644
--- a/src/scripts/ipsec-interfaces
+++ b/src/scripts/ipsec-interfaces
@@ -44,25 +44,6 @@ main() {
 
 	local interfaces=()
 
-	# Compat for older connections
-	if [ "${local}" = "off" ]; then
-		if [ "${VPN_IP}" = "%defaultroute" ]; then
-			local=""
-		else
-			local="${VPN_IP}"
-		fi
-	fi
-
-	# Handle %defaultroute
-	if [ -z "${local}" ]; then
-		if [ -r "/var/ipfire/red/local-ipaddress" ]; then
-			local="$(</var/ipfire/red/local-ipaddress)"
-
-		elif [ "${RED_TYPE}" = "STATIC" -a -n "${RED_ADDRESS}" ]; then
-			local="${RED_ADDRESS}"
-		fi
-	fi
-
 	# We are done when IPsec is not enabled
 	if [ "${ENABLED}" = "on" ]; then
 		while IFS="," read -r "${VARS[@]}"; do
@@ -85,6 +66,25 @@ main() {
 			# Add the interface to the list of all interfaces
 			interfaces+=( "${intf}" )
 
+			# Compat for older connections
+			if [ "${local}" = "off" ]; then
+				if [ "${VPN_IP}" = "%defaultroute" ]; then
+					local=""
+				else
+					local="${VPN_IP}"
+				fi
+			fi
+
+			# Handle %defaultroute
+			if [ -z "${local}" ]; then
+				if [ -r "/var/ipfire/red/local-ipaddress" ]; then
+					local="$(</var/ipfire/red/local-ipaddress)"
+
+				elif [ "${RED_TYPE}" = "STATIC" -a -n "${RED_ADDRESS}" ]; then
+					local="${RED_ADDRESS}"
+				fi
+			fi
+
 			local args=(
 				"local" "${local}"
 				"remote" "${remote}"
-- 
2.39.5