From daf718f4594a9f359488481aa526c5f7638eb7fd Mon Sep 17 00:00:00 2001
From: Eduardo San Martin Morote <posva13@gmail.com>
Date: Tue, 4 Aug 2020 16:22:58 +0200
Subject: [PATCH] chore: add todo about optional params

---
 src/matcher/index.ts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/matcher/index.ts b/src/matcher/index.ts
index 7111a18d..1bb7b07a 100644
--- a/src/matcher/index.ts
+++ b/src/matcher/index.ts
@@ -228,6 +228,8 @@ export function createRouterMatcher(
         // paramsFromLocation is a new object
         paramsFromLocation(
           currentLocation.params,
+          // only keep params that exist in the resolved location
+          // TODO: only keep optional params coming from a parent record
           matcher.keys.map(k => k.name)
         ),
         location.params
-- 
2.47.2