From db6108d3ac91b7f09df366e0627d81803c703513 Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Wed, 23 Apr 2025 17:20:33 -0700 Subject: [PATCH] arm64/crc: drop "glue" from filenames The use of the term "glue" in filenames is a Crypto API-ism that rarely shows up elsewhere in lib/ or arch/*/lib/. I think adopting it there was a mistake. The library just uses standard functions, so the amount of code that could be considered "glue" is quite small. And while often the C functions just wrap the assembly functions, there are also cases like crc32c_arch() in arch/x86/lib/crc32-glue.c that blur the line by in-lining the actual implementation into the C function. That's not "glue code", but rather the actual code. Therefore, let's drop "glue" from the filenames and instead use e.g. crc32.c instead of crc32-glue.c. Reviewed-by: "Martin K. Petersen" Acked-by: Ard Biesheuvel Link: https://lore.kernel.org/r/20250424002038.179114-3-ebiggers@kernel.org Signed-off-by: Eric Biggers --- arch/arm64/lib/Makefile | 4 ++-- arch/arm64/lib/{crc-t10dif-glue.c => crc-t10dif.c} | 0 arch/arm64/lib/{crc32.S => crc32-core.S} | 0 arch/arm64/lib/{crc32-glue.c => crc32.c} | 0 4 files changed, 2 insertions(+), 2 deletions(-) rename arch/arm64/lib/{crc-t10dif-glue.c => crc-t10dif.c} (100%) rename arch/arm64/lib/{crc32.S => crc32-core.S} (100%) rename arch/arm64/lib/{crc32-glue.c => crc32.c} (100%) diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile index 4d49dff721a84..d97e290619bc5 100644 --- a/arch/arm64/lib/Makefile +++ b/arch/arm64/lib/Makefile @@ -14,10 +14,10 @@ endif lib-$(CONFIG_ARCH_HAS_UACCESS_FLUSHCACHE) += uaccess_flushcache.o obj-$(CONFIG_CRC32_ARCH) += crc32-arm64.o -crc32-arm64-y := crc32.o crc32-glue.o +crc32-arm64-y := crc32.o crc32-core.o obj-$(CONFIG_CRC_T10DIF_ARCH) += crc-t10dif-arm64.o -crc-t10dif-arm64-y := crc-t10dif-glue.o crc-t10dif-core.o +crc-t10dif-arm64-y := crc-t10dif.o crc-t10dif-core.o obj-$(CONFIG_FUNCTION_ERROR_INJECTION) += error-inject.o diff --git a/arch/arm64/lib/crc-t10dif-glue.c b/arch/arm64/lib/crc-t10dif.c similarity index 100% rename from arch/arm64/lib/crc-t10dif-glue.c rename to arch/arm64/lib/crc-t10dif.c diff --git a/arch/arm64/lib/crc32.S b/arch/arm64/lib/crc32-core.S similarity index 100% rename from arch/arm64/lib/crc32.S rename to arch/arm64/lib/crc32-core.S diff --git a/arch/arm64/lib/crc32-glue.c b/arch/arm64/lib/crc32.c similarity index 100% rename from arch/arm64/lib/crc32-glue.c rename to arch/arm64/lib/crc32.c -- 2.39.5