From dbd0bc6bd2d1f0c1c7a88a8497f1276433816877 Mon Sep 17 00:00:00 2001 From: Eduardo San Martin Morote Date: Tue, 27 Dec 2022 14:00:29 +0100 Subject: [PATCH] chore: note about beforeunload --- packages/router/src/history/html5.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/router/src/history/html5.ts b/packages/router/src/history/html5.ts index bc4531f9..6aeda01a 100644 --- a/packages/router/src/history/html5.ts +++ b/packages/router/src/history/html5.ts @@ -144,7 +144,11 @@ function useHistoryListeners( // set up the listeners and prepare teardown callbacks window.addEventListener('popstate', popStateHandler) - window.addEventListener('beforeunload', beforeUnloadListener) + // TODO: could we use 'pagehide' or 'visibilitychange' instead? + // https://developer.chrome.com/blog/page-lifecycle-api/ + window.addEventListener('beforeunload', beforeUnloadListener, { + passive: true, + }) return { pauseListeners, -- 2.47.2