From ddd75166dd41ea2f5643155bc8f8060472b50f09 Mon Sep 17 00:00:00 2001 From: Vincent Bernat Date: Fri, 22 Nov 2013 23:20:30 +0100 Subject: [PATCH] coverity: remove a theoritical memory leak If cargc is 0, cargv should not have been allocated. However, to be more robust, let's say this is possible and handle this case correctly. --- src/client/lldpcli.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/client/lldpcli.c b/src/client/lldpcli.c index 8d96fd06..5498c579 100644 --- a/src/client/lldpcli.c +++ b/src/client/lldpcli.c @@ -305,10 +305,12 @@ parse_and_exec(lldpctl_conn_t *conn, const char *fmt, const char *line) log_warnx("lldpctl", "unmatched quotes"); return -1; } - if (cargc == 0) return 0; - n = cmd_exec(conn, fmt, cargc, (const char **)cargv); + if (cargc != 0) + n = cmd_exec(conn, fmt, cargc, (const char **)cargv); tokenize_free(cargc, cargv); - return (n == 0)?-1:1; + return (cargc == 0)?0: + (n == 0)?-1: + 1; } static struct cmd_node* -- 2.39.5