From de49759a0e28657db53a1e1c8425ea72632dac95 Mon Sep 17 00:00:00 2001 From: Neil Conway Date: Fri, 21 Jan 2005 00:17:02 +0000 Subject: [PATCH] Prevent overrunning a heap-allocated buffer is more than 1024 parameters to a refcursor declaration are specified. This is a minimally-invasive fix for the buffer overrun -- a more thorough cleanup will be checked into HEAD. --- src/pl/plpgsql/src/gram.y | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/pl/plpgsql/src/gram.y b/src/pl/plpgsql/src/gram.y index c1d0f6c90ab..908fd364a9b 100644 --- a/src/pl/plpgsql/src/gram.y +++ b/src/pl/plpgsql/src/gram.y @@ -4,7 +4,7 @@ * procedural language * * IDENTIFICATION - * $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.64 2004/10/25 06:27:21 neilc Exp $ + * $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.64.4.1 2005/01/21 00:17:02 neilc Exp $ * * This software is copyrighted by Jan Wieck - Hamburg. * @@ -474,6 +474,10 @@ decl_cursor_arglist : decl_cursor_arg { int i = $1->nfields++; + /* Guard against overflowing the array on malicious input */ + if (i >= 1024) + yyerror("too many parameters specified for refcursor"); + $1->fieldnames[i] = $3->refname; $1->varnos[i] = $3->dno; -- 2.39.5