From de4bc0ea069c0aeb094d8ed0fd25d8cbbf3912e8 Mon Sep 17 00:00:00 2001 From: Alex Rousskov Date: Fri, 4 Feb 2011 15:25:45 -0700 Subject: [PATCH] Quiet down swap out error reporting. Do not report swap out errors at level 1. When things go wrong, the already bad situation is made worse by writing lots of error messages to cache.log. Do not report system error because the errno may be stale or irrelevant. If error details are needed, the code should save and propagate the actual errno in addition to the DISK_ERROR or similar status. --- src/store_swapout.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/store_swapout.cc b/src/store_swapout.cc index b0981da071..d8da216976 100644 --- a/src/store_swapout.cc +++ b/src/store_swapout.cc @@ -325,10 +325,9 @@ storeSwapOutFileClosed(void *data, int errflag, StoreIOState::Pointer self) cbdataFree(c); if (errflag) { - debugs(20, 1, "storeSwapOutFileClosed: dirno " << e->swap_dirn << ", swapfile " << + debugs(20, 2, "storeSwapOutFileClosed: dirno " << e->swap_dirn << ", swapfile " << std::hex << std::setw(8) << std::setfill('0') << std::uppercase << e->swap_filen << ", errflag=" << errflag); - debugs(20, 1, "\t" << xstrerror()); if (errflag == DISK_NO_SPACE_LEFT) { /* FIXME: this should be handle by the link from store IO to -- 2.47.2