From dec394e08c3572463f8246d176c5d6b572f4ac95 Mon Sep 17 00:00:00 2001 From: Marc Fournier Date: Tue, 10 Jan 2017 22:23:55 +0100 Subject: [PATCH] logfile: send log messages to STDERR by default This prevents early startup log messages from going unnoticed if the default logfile isn't writeable. Fixes: #2057 --- src/logfile.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/logfile.c b/src/logfile.c index 0de639e96..eca8c3475 100644 --- a/src/logfile.c +++ b/src/logfile.c @@ -31,8 +31,6 @@ #include "common.h" #include "plugin.h" -#define DEFAULT_LOGFILE LOCALSTATEDIR "/log/collectd.log" - #if COLLECT_DEBUG static int log_level = LOG_DEBUG; #else @@ -117,8 +115,7 @@ static void logfile_print(const char *msg, int severity, pthread_mutex_lock(&file_lock); if (log_file == NULL) { - fh = fopen(DEFAULT_LOGFILE, "a"); - do_close = 1; + fh = stderr; } else if (strcasecmp(log_file, "stderr") == 0) fh = stderr; else if (strcasecmp(log_file, "stdout") == 0) @@ -130,8 +127,7 @@ static void logfile_print(const char *msg, int severity, if (fh == NULL) { char errbuf[1024]; - fprintf(stderr, "logfile plugin: fopen (%s) failed: %s\n", - (log_file == NULL) ? DEFAULT_LOGFILE : log_file, + fprintf(stderr, "logfile plugin: fopen (%s) failed: %s\n", log_file, sstrerror(errno, errbuf, sizeof(errbuf))); } else { if (print_timestamp) -- 2.39.5