From e172ee7b999a9b6438284ec89e989a73eda4f3f3 Mon Sep 17 00:00:00 2001 From: Vincent Bernat Date: Thu, 4 Dec 2014 00:56:51 +0100 Subject: [PATCH] lldpd: decrease probability of collisions on port checksums Instead of wasting a whole bit (getting 2**15 valid values), just waste one special value (2**16-1 valid values). --- src/daemon/lldpd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/daemon/lldpd.c b/src/daemon/lldpd.c index dfbce73c..8de5187b 100644 --- a/src/daemon/lldpd.c +++ b/src/daemon/lldpd.c @@ -315,7 +315,7 @@ lldpd_reset_timer(struct lldpd *cfg) /* Port change is detected by computing a checksum. 0 means the * checksum never was computed (new interface). */ cksum = frame_checksum(output, output_len, 0); - cksum |= 1; + cksum = cksum?cksum:1; free(output); if (cksum != hardware->h_lport_cksum) { log_debug("localchassis", -- 2.39.5