From e1cbdd805317095b05534c2f734f7084f88d83b3 Mon Sep 17 00:00:00 2001 From: dklawren Date: Fri, 15 May 2020 11:36:39 -0400 Subject: [PATCH] Bug 1638022 - Phabbugz should not try to set needs-review when the revision is closed or abandoned --- extensions/PhabBugz/lib/Feed.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/extensions/PhabBugz/lib/Feed.pm b/extensions/PhabBugz/lib/Feed.pm index baa887677..a3290fbbe 100644 --- a/extensions/PhabBugz/lib/Feed.pm +++ b/extensions/PhabBugz/lib/Feed.pm @@ -520,12 +520,14 @@ sub process_revision_change { } # Set status to request-review if revision is new and - # in draft state and not changes-planned + # in draft state and not changes-planned, closed, or abandoned. if ($is_new && $revision->status ne 'changes-planned' + && $revision->status ne 'closed' + && $revision->status ne 'abandoned' && ($revision->is_draft && !$revision->hold_as_draft)) { - INFO("Moving from draft to needs-review"); + INFO('Moving from draft to needs-review'); $revision->set_status('request-review'); } -- 2.47.3