From e24c7580cb79f547e0a9f838b2f3d5962eb6cfac Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Mon, 27 Jul 2009 23:17:51 +0200 Subject: [PATCH] fix migration to obey -S Since migration returns right away, starting the VM right after calling qemu_start_incoming_migration is wrong even if -S is not passed. We have to do this after migration has completed. Cc: Glauber Costa Cc: Anthony Liguori Signed-off-by: Anthony Liguori Signed-off-by: Glauber Costa --- migration-exec.c | 2 ++ migration-tcp.c | 2 ++ sysemu.h | 1 + vl.c | 4 ++-- 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/migration-exec.c b/migration-exec.c index 2e7fdc21dd1..ade592eca06 100644 --- a/migration-exec.c +++ b/migration-exec.c @@ -122,6 +122,8 @@ static void exec_accept_incoming_migration(void *opaque) dprintf("successfully loaded vm state\n"); /* we've successfully migrated, close the fd */ qemu_set_fd_handler2(qemu_popen_fd(f), NULL, NULL, NULL, NULL); + if (autostart) + vm_start(); err: qemu_fclose(f); diff --git a/migration-tcp.c b/migration-tcp.c index 0875c23c985..5466e575579 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -170,6 +170,8 @@ static void tcp_accept_incoming_migration(void *opaque) /* we've successfully migrated, close the server socket */ qemu_set_fd_handler2(s, NULL, NULL, NULL, NULL); close(s); + if (autostart) + vm_start(); out_fopen: qemu_fclose(f); diff --git a/sysemu.h b/sysemu.h index 57217c1ebcf..f549f29b94b 100644 --- a/sysemu.h +++ b/sysemu.h @@ -77,6 +77,7 @@ int tap_win32_init(VLANState *vlan, const char *model, /* SLIRP */ void do_info_slirp(void); +extern int autostart; extern int bios_size; extern int cirrus_vga_enabled; extern int std_vga_enabled; diff --git a/vl.c b/vl.c index 0e4672785a1..f1244c96eb4 100644 --- a/vl.c +++ b/vl.c @@ -201,7 +201,7 @@ ram_addr_t ram_size; int nb_nics; NICInfo nd_table[MAX_NICS]; int vm_running; -static int autostart; +int autostart; static int rtc_utc = 1; static int rtc_date_offset = -1; /* -1 means no change */ int cirrus_vga_enabled = 1; @@ -5726,7 +5726,7 @@ int main(int argc, char **argv, char **envp) qemu_start_incoming_migration(incoming); } - if (autostart) + else if (autostart) vm_start(); if (daemonize) { -- 2.39.5