From e5c99c0811199a734ed0fe41784d22230922a49a Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Tue, 6 Jul 2010 11:57:09 +1000 Subject: [PATCH] Assemble: Fix honouring of 'auto' config line commit 1ff98339283645a20c980d540f6c4d82693e7daf broke the checking of metadata types via the 'auto' line. Be moving 'load_super" before "conf_test_metadata" we left tst->sb set even if conf_test_metadata fails, so the device will actually be accepted and used. So if we decide to reject the device, free the superblock so it is clear that it is rejected. Signed-off-by: NeilBrown --- Assemble.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Assemble.c b/Assemble.c index 1504f1f4..c5d28edc 100644 --- a/Assemble.c +++ b/Assemble.c @@ -271,6 +271,7 @@ int Assemble(struct supertype *st, char *mddev, fprintf(stderr, Name ": %s has metadata type %s for which " "auto-assembly is disabled\n", devname, tst->ss->name); + tst->ss->free_super(tst); tmpdev->used = 2; } else { content = &info; -- 2.47.3