From e6a4245d2a4db3857cfb38d4d3c4e3e0bcff6587 Mon Sep 17 00:00:00 2001
From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 9 Jan 2025 15:18:58 +0100
Subject: [PATCH] virstoragetest: Add case for qcow2 image with empty string as
 'data_file'

Add an example image formatted by:

 qemu-img create -f qcow2 -o data_file=nbd+unix:///datafile?socket=/tmp/nbd,data_file_raw=true /tmp/nbddatastore.qcow2 10M -u

serving as an example when qemu records an empty string as the
'data_file' field.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---
 tests/virstoragetest.c                         |   5 +++++
 .../images/datafile-emptystr.qcow2             | Bin 0 -> 327680 bytes
 2 files changed, 5 insertions(+)
 create mode 100644 tests/virstoragetestdata/images/datafile-emptystr.qcow2

diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
index 4ec837eefb..78dc644637 100644
--- a/tests/virstoragetest.c
+++ b/tests/virstoragetest.c
@@ -494,6 +494,11 @@ mymain(void)
                abs_srcdir "/virstoragetestdata/images/qcow2datafile-datafile.qcow2",
                VIR_STORAGE_FILE_QCOW2, EXP_PASS);
 
+    /* broken qcow2 with a 'data_file' which is an empty string */
+    TEST_CHAIN("qcow2-datafile-broken",
+               abs_srcdir "/virstoragetestdata/images/datafile-emptystr.qcow2",
+               VIR_STORAGE_FILE_QCOW2, EXP_FAIL);
+
     /* Test various combinations of qcow2 images with missing 'backing_format' */
     TEST_CHAIN("qcow2-qcow2_qcow2-qcow2_qcow2-auto",
                abs_srcdir "/virstoragetestdata/images/qcow2_qcow2-qcow2_qcow2-auto.qcow2",
diff --git a/tests/virstoragetestdata/images/datafile-emptystr.qcow2 b/tests/virstoragetestdata/images/datafile-emptystr.qcow2
new file mode 100644
index 0000000000000000000000000000000000000000..18fae8740b4d650252d9a20629ca6e4d04653692
GIT binary patch
literal 327680
zc-rmIK}y3w6adgk(gS#eoWUCuL=fBvg6r5!F;LSmNzuCMu?07_YK1Da+4sGH8UAPH
zGymUR-+Y7+ig4)S`^fik_O%xWQ5OE2{E73QT(?hLP4B0>^Qm}$*p}FYP&a8<mygX5
zM#*N&lvdp^_C+3FhnU)GQP$N^mGfp1kKQk4%jYh|zHgRoIjp;QqW)x8zpZ0k-d>im
z9a0nfW8V*p>TO-7IG-(7?a-h6e%SW;Ty_1p>4ZE>)k}HMa{vGU000000000000000
z0000000000000000000000000000000000000000000000000000000000007%evf
z00000000000000000000000000000000000000000000000000000000000000000
z0000000000004lqm;EjP000000000000000000000000000000000000000000000
z000000000000000000000000000000007R|X17hu0RR9100000000000000000000
z000000000000000000000000000000000000000000000000000002s+--~i00000
z00000000000000000000000000000000000000000000000000000000000000000
M00000004lkPs5Bdga7~l

literal 0
Hc-jL100001

-- 
2.47.3