From e7b393bfef712c3588654d1c55b81859e521e1aa Mon Sep 17 00:00:00 2001 From: Eduardo San Martin Morote Date: Fri, 20 Aug 2021 11:45:06 +0200 Subject: [PATCH] chore: rename --- .../__tests__/apiCustomElement.spec.ts | 36 +++++++++---------- packages/runtime-dom/src/apiCustomElement.ts | 4 +-- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/packages/runtime-dom/__tests__/apiCustomElement.spec.ts b/packages/runtime-dom/__tests__/apiCustomElement.spec.ts index accd1d38d0..96fb6dfe7d 100644 --- a/packages/runtime-dom/__tests__/apiCustomElement.spec.ts +++ b/packages/runtime-dom/__tests__/apiCustomElement.spec.ts @@ -1,36 +1,36 @@ -import { toNumber } from '../src/apiCustomElement' +import { parseNumber } from '../src/apiCustomElement' describe('Custom Element', () => { - describe('toNumber', () => { + describe('parseNumber', () => { it('handles strings', () => { - expect(toNumber('')).toBe('') - expect(toNumber(null)).toBe('') - expect(toNumber('Something else')).toBe('Something else') + expect(parseNumber('')).toBe('') + expect(parseNumber(null)).toBe('') + expect(parseNumber('Something else')).toBe('Something else') }) it('numbers', () => { - expect(toNumber('0')).toBe(0) - expect(toNumber('1')).toBe(1) - expect(toNumber('1.1')).toBe(1.1) - expect(toNumber('123e-1')).toBe(12.3) - expect(toNumber('Infinity')).toBe(Infinity) + expect(parseNumber('0')).toBe(0) + expect(parseNumber('1')).toBe(1) + expect(parseNumber('1.1')).toBe(1.1) + expect(parseNumber('123e-1')).toBe(12.3) + expect(parseNumber('Infinity')).toBe(Infinity) }) it('NaN', () => { - expect(toNumber('NaN')).toBeNaN() - expect(toNumber('nan')).not.toBeNaN() + expect(parseNumber('NaN')).toBeNaN() + expect(parseNumber('nan')).not.toBeNaN() }) // all of these are handled by Number it('string non decimal bases', () => { - expect(toNumber('0b0')).toBe(0) - expect(toNumber('0b1')).toBe(1) + expect(parseNumber('0b0')).toBe(0) + expect(parseNumber('0b1')).toBe(1) - expect(toNumber('0o3')).toBe(3) - expect(toNumber('0o0')).toBe(0) + expect(parseNumber('0o3')).toBe(3) + expect(parseNumber('0o0')).toBe(0) - expect(toNumber('0x0')).toBe(0) - expect(toNumber('0xf')).toBe(15) + expect(parseNumber('0x0')).toBe(0) + expect(parseNumber('0xf')).toBe(15) }) }) }) diff --git a/packages/runtime-dom/src/apiCustomElement.ts b/packages/runtime-dom/src/apiCustomElement.ts index bbea883ef4..f43d75deea 100644 --- a/packages/runtime-dom/src/apiCustomElement.ts +++ b/packages/runtime-dom/src/apiCustomElement.ts @@ -246,7 +246,7 @@ export class VueElement extends BaseClass { } protected _setAttr(key: string) { - this._setProp(camelize(key), toNumber(this.getAttribute(key)), false) + this._setProp(camelize(key), parseNumber(this.getAttribute(key)), false) } /** @@ -343,7 +343,7 @@ export class VueElement extends BaseClass { } } -export function toNumber(value: string | null): number | string { +export function parseNumber(value: string | null): number | string { // for Number('') and Number(null) as they both become 0 if (!value) return '' const casted = Number(value) -- 2.47.2