From e7e2b21d274ef48da4e45d09786568d2239c9b2a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Mon, 5 Oct 2020 12:33:07 +0200 Subject: [PATCH] BUG/MINOR: peers: Inconsistency when dumping peer status codes. A peer connection status must be considered as valid only if there is an applet which has been instantiated for the connection to the peer. So, ->statuscode should be considered as the last known peer connection status from the last connection to this peer if any. To reflect this, "statuscode" field of peer dump is renamed to "last_statuscode". This patch also add "active"/"inactive" field after the peer location type ("remote" or "local") if an applet has been instantiated for this peer connection or not. Thank you to Emeric for having noticed this issue. Must be backported in >=1.9 version. --- src/peers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/peers.c b/src/peers.c index fcea37ec1c..d76a1f8765 100644 --- a/src/peers.c +++ b/src/peers.c @@ -3099,9 +3099,10 @@ static int peers_dump_peer(struct buffer *msg, struct stream_interface *si, stru struct shared_table *st; addr_to_str(&peer->addr, pn, sizeof pn); - chunk_appendf(msg, " %p: id=%s(%s) addr=%s:%d status=%s reconnect=%s confirm=%u tx_hbt=%u rx_hbt=%u no_hbt=%u new_conn=%u proto_err=%u\n", + chunk_appendf(msg, " %p: id=%s(%s,%s) addr=%s:%d last_status=%s reconnect=%s confirm=%u tx_hbt=%u rx_hbt=%u no_hbt=%u new_conn=%u proto_err=%u\n", peer, peer->id, peer->local ? "local" : "remote", + peer->appctx ? "active" : "inactive", pn, get_host_port(&peer->addr), statuscode_str(peer->statuscode), peer->reconnect ? -- 2.47.3