From e9ffa312ff06cde77c4a6395c411c5ebde738f04 Mon Sep 17 00:00:00 2001 From: Yunseong Kim Date: Thu, 20 Jun 2024 05:34:29 +0900 Subject: [PATCH] util: constant -1 with expression of type char This patch resolve following warning. tools/perf/util/evsel.c:1620:9: error: result of comparison of constant -1 with expression of type 'char' is always false -Werror,-Wtautological-constant-out-of-range-compare 1620 | if (c == -1) | ~ ^ ~~ Signed-off-by: Yunseong Kim Reviewed-by: Ian Rogers Cc: Ravi Bangoria Cc: Austin Kim Cc: shjy180909@gmail.com Cc: Ze Gao Cc: Leo Yan Signed-off-by: Namhyung Kim Link: https://lore.kernel.org/r/20240619203428.6330-2-yskelg@gmail.com --- tools/perf/util/evsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 25857894c0479..bc603193c4777 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1620,7 +1620,7 @@ static int evsel__read_group(struct evsel *leader, int cpu_map_idx, int thread) static bool read_until_char(struct io *io, char e) { - char c; + int c; do { c = io__get_char(io); -- 2.39.5