From ea55bf64b231726d7e0a1067b6bbb130524185b6 Mon Sep 17 00:00:00 2001 From: Tobias Stoeckmann Date: Sun, 8 Oct 2023 20:21:04 +0200 Subject: [PATCH] login: use xasprintf It is easier to use xasprintf than performing all its internals explicitly in login's code base. Signed-off-by: Tobias Stoeckmann --- login-utils/login.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/login-utils/login.c b/login-utils/login.c index 36956cce75..1f3f5d36c1 100644 --- a/login-utils/login.c +++ b/login-utils/login.c @@ -861,8 +861,7 @@ static void loginpam_err(pam_handle_t *pamh, int retcode) static const char *loginpam_get_prompt(struct login_context *cxt) { const char *host; - char *prompt, *dflt_prompt = _("login: "); - size_t sz; + char *prompt = NULL, *dflt_prompt = _("login: "); if (cxt->nohost) return dflt_prompt; /* -H on command line */ @@ -873,9 +872,7 @@ static const char *loginpam_get_prompt(struct login_context *cxt) if (!(host = get_thishost(cxt, NULL))) return dflt_prompt; - sz = strlen(host) + 1 + strlen(dflt_prompt) + 1; - prompt = xmalloc(sz); - snprintf(prompt, sz, "%s %s", host, dflt_prompt); + xasprintf(&prompt, "%s %s", host, dflt_prompt); return prompt; } -- 2.47.2