From ec08dd3f1ecf70a647cc56ad5447abe41b833ddb Mon Sep 17 00:00:00 2001 From: Harsh Parekh Date: Thu, 27 Feb 2025 11:45:44 -0500 Subject: [PATCH] Format HTTPError.log_message only if args provided Attempts to fix the [jupyter_server/issues/1503](https://github.com/jupyter-server/jupyter_server/issues/1503) issue --- tornado/web.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tornado/web.py b/tornado/web.py index 357c5f1a..3003fd8e 100644 --- a/tornado/web.py +++ b/tornado/web.py @@ -2520,8 +2520,6 @@ class HTTPError(Exception): self.log_message = log_message self.args = args self.reason = kwargs.get("reason", None) - if log_message and not args: - self.log_message = log_message.replace("%", "%%") def __str__(self) -> str: message = "HTTP %d: %s" % ( @@ -2529,7 +2527,8 @@ class HTTPError(Exception): self.reason or httputil.responses.get(self.status_code, "Unknown"), ) if self.log_message: - return message + " (" + (self.log_message % self.args) + ")" + log_message = (self.log_message % self.args) if self.args else self.log_message + return message + " (" + log_message + ")" else: return message -- 2.47.3