From f1b1881dfed9e8f4b2487aa74f6d151b1047539f Mon Sep 17 00:00:00 2001 From: Ngie Cooper Date: Sat, 10 Dec 2016 16:24:35 -0800 Subject: [PATCH] Don't leak the file descriptor pointed to by `in` if the first call to fgets fails. Reported by: Coverity CID: 1331677 --- tar/test/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tar/test/main.c b/tar/test/main.c index 6bc355783..9bb7964c4 100644 --- a/tar/test/main.c +++ b/tar/test/main.c @@ -2324,7 +2324,7 @@ extract_reference_file(const char *name) for (;;) { if (fgets(buff, sizeof(buff), in) == NULL) { /* TODO: This is a failure. */ - return; + goto done; } if (memcmp(buff, "begin ", 6) == 0) break; @@ -2365,6 +2365,7 @@ extract_reference_file(const char *name) } } fclose(out); +done: fclose(in); } -- 2.47.3