From f93a0f3fd67bb12ba5efe05652f822585e018a84 Mon Sep 17 00:00:00 2001 From: Frank Lichtenheld Date: Fri, 17 Oct 2025 22:49:09 +0200 Subject: [PATCH] ssl_util: Fix conversion warning in get_num_elements Just use correct type. Change-Id: I2d1fbe7ec080beb931253d09c1b5227e9bf4e756 Signed-off-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1281 Message-Id: <20251017204914.7548-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33421.html Signed-off-by: Gert Doering --- src/openvpn/ssl_util.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/openvpn/ssl_util.c b/src/openvpn/ssl_util.c index 50e8c03ad..fb7cf3eb6 100644 --- a/src/openvpn/ssl_util.c +++ b/src/openvpn/ssl_util.c @@ -290,21 +290,16 @@ tls_get_cipher_name_pair(const char *cipher_name, size_t len) return NULL; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif - int get_num_elements(const char *string, char delimiter) { - int string_len = strlen(string); + const size_t string_len = strlen(string); ASSERT(0 != string_len); int element_count = 1; /* Get number of ciphers */ - for (int i = 0; i < string_len; i++) + for (size_t i = 0; i < string_len; i++) { if (string[i] == delimiter) { @@ -314,7 +309,3 @@ get_num_elements(const char *string, char delimiter) return element_count; } - -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif -- 2.47.3