From f98299ec2fa65804ceeff634fa50c8d154e1c153 Mon Sep 17 00:00:00 2001 From: Changqing Li Date: Thu, 20 Feb 2025 11:57:24 +0800 Subject: [PATCH] Revert "python3-ctypes: depend on ldconfig only if distro-feature set" In oe-core, function ldconfig_postinst_fragment use exist of /sbin/ldconfig to decide if ldconfig is runned to generate the cache, and function _run_ldconfig will run ldconfig to generate cache during generate rootfs. ldconfig.service is actually not used since we have generate ld.so.cache during do_rootfs, refer[1][2][3]. ldconfig dependency is necessary when ldconfig not in DISTRO_FEATURES. The reverted commit causes regression when ldconfig not in DISTRO_FEATURES, before, without ldconfig in DISTRO_FEATURES, ctypes.util.find_library(name) can find the lib if it is installed, now, since ldconfig is not installed, ctypes.util.find_library(name) cannot find the lib even if it is installed. Here is one usecase(gtk+3 lib is installed, ctypes.util.find_library used to find the lib): import wx.lib.wxcairo as wxcairo File "/usr/lib/python3.13/site-packages/wx/lib/wxcairo/{}init{}.py", line 59, in from .wx_cairocffi import _ContextFromDC, _FontFaceFromFont File "/usr/lib/python3.13/site-packages/wx/lib/wxcairo/wx_cairocffi.py", line 189, in gdkLib = _findGDKLib() File "/usr/lib/python3.13/site-packages/wx/lib/wxcairo/wx_cairocffi.py", line 181, in _findGDKLib return _findHelper([libname], 'gdk', "Unable to find the GDK shared library") File "/usr/lib/python3.13/site-packages/wx/lib/wxcairo/wx_cairocffi.py", line 170, in _findHelper raise RuntimeError(msg) RuntimeError: Unable to find the GDK shared library [1] https://git.openembedded.org/openembedded-core/tree/meta/classes-global/package.bbclass#n394 [2] https://git.openembedded.org/openembedded-core/tree/meta/lib/oe/rootfs.py#n316 [3] https://github.com/systemd/systemd-stable/blob/v255-stable/units/ldconfig.service Signed-off-by: Changqing Li Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie --- meta/recipes-devtools/python/python3_3.13.2.bb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/meta/recipes-devtools/python/python3_3.13.2.bb b/meta/recipes-devtools/python/python3_3.13.2.bb index 96478856b34..2010f6b7d14 100644 --- a/meta/recipes-devtools/python/python3_3.13.2.bb +++ b/meta/recipes-devtools/python/python3_3.13.2.bb @@ -477,9 +477,7 @@ FILES:${PN}-man = "${datadir}/man" # See https://bugs.python.org/issue18748 and https://bugs.python.org/issue37395 RDEPENDS:libpython3:append:libc-glibc = " libgcc" -RDEPENDS:${PN}-ctypes:append:libc-glibc = "\ - ${@bb.utils.contains('DISTRO_FEATURES', 'ldconfig', '${MLPREFIX}ldconfig', '', d)} \ -" +RDEPENDS:${PN}-ctypes:append:libc-glibc = " ${MLPREFIX}ldconfig" RDEPENDS:${PN}-ptest = "\ ${PN}-dev \ ${PN}-modules \ -- 2.47.3