From fb9c3a83a5384126722a485639d2d95ef85c3b46 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 29 Apr 2025 20:47:42 +0000 Subject: [PATCH] clone: don't dup(2) stdout FD Avoiding close(2) on stdout doesn't seem to be worth it anyways, as lei code shouldn't be closing FDs unless they fail (e.g. SIGPIPE), in which case keeping a duplicate FD isn't doing any good, anyways. --- script/public-inbox-clone | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/script/public-inbox-clone b/script/public-inbox-clone index 5ecf11ae7..c7131d264 100755 --- a/script/public-inbox-clone +++ b/script/public-inbox-clone @@ -54,9 +54,8 @@ require PublicInbox::LeiMirror; $url = PublicInbox::LeiExternal::ext_canonicalize($url); my $lei = bless { env => \%ENV, opt => $opt, cmd => 'public-inbox-clone', - 0 => \*STDIN, 2 => \*STDERR, + 0 => \*STDIN, 1 => \*STDOUT, 2 => \*STDERR, }, 'PublicInbox::LEI'; -open $lei->{1}, '+<&=', 1 or die "dup: $!"; open $lei->{3}, '.' or die "open . $!"; my $mrr = bless { lei => $lei, -- 2.47.3