From fcd6672d6c9e512891f472d1a038d6e243be9488 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Sat, 13 Sep 2025 12:36:33 +0200 Subject: [PATCH] [gdb/testsuite] Fix test names in gdb.tui/{empty,new-layout}.exp Post-commit review [1] pointed out that this change in gdb.tui/empty.exp: ... - eval Term::check_box [list "box $boxno"] $box + Term::check_box [list "box $boxno"] {*}$box ... is incomplete because it leaves the "[list ...]" in place. Indeed, it changes the test name like this: ... -PASS: gdb.tui/empty.exp: src: 80x24: box 1 +PASS: gdb.tui/empty.exp: src: 80x24: {box 1} ... Fix this by dropping the "[list ...]". Likewise in gdb.tui/new-layout.exp. [1] https://sourceware.org/pipermail/gdb-patches/2025-September/220863.html --- gdb/testsuite/gdb.tui/empty.exp | 2 +- gdb/testsuite/gdb.tui/new-layout.exp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.tui/empty.exp b/gdb/testsuite/gdb.tui/empty.exp index c6dad300d34..19196e8ecbf 100644 --- a/gdb/testsuite/gdb.tui/empty.exp +++ b/gdb/testsuite/gdb.tui/empty.exp @@ -65,7 +65,7 @@ set layouts { proc check_boxes {boxes} { set boxno 1 foreach box $boxes { - Term::check_box [list "box $boxno"] {*}$box + Term::check_box "box $boxno" {*}$box incr boxno } } diff --git a/gdb/testsuite/gdb.tui/new-layout.exp b/gdb/testsuite/gdb.tui/new-layout.exp index 11521b03ca3..6a4c68f7ebe 100644 --- a/gdb/testsuite/gdb.tui/new-layout.exp +++ b/gdb/testsuite/gdb.tui/new-layout.exp @@ -81,7 +81,7 @@ set layouts \ proc check_boxes {boxes} { set boxno 1 foreach box $boxes { - Term::check_box [list "box $boxno"] {*}$box + Term::check_box "box $boxno" {*}$box incr boxno } } -- 2.47.3