From fd2b2429fbc859b398385da69c85515851f2c0e5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Niklas=20S=C3=B6derlund?= Date: Mon, 8 Sep 2025 17:44:26 +0200 Subject: [PATCH] net: ethernet: renesas: rcar_gen4_ptp: Use lockdep to verify internal usage MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Instead of a having a comment that the lock must be held when calling the internal helper add a lockdep check to enforce it. Signed-off-by: Niklas Söderlund Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250908154426.3062861-4-niklas.soderlund+renesas@ragnatech.se Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c index cf13eba9b65e1..d0979abd36de4 100644 --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c @@ -42,12 +42,13 @@ static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) return 0; } -/* Caller must hold the lock */ static void _rcar_gen4_ptp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts) { struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp); + lockdep_assert_held(&ptp_priv->lock); + ts->tv_nsec = ioread32(ptp_priv->addr + PTPGPTPTM00_REG); ts->tv_sec = ioread32(ptp_priv->addr + PTPGPTPTM10_REG) | ((s64)ioread32(ptp_priv->addr + PTPGPTPTM20_REG) << 32); -- 2.47.3