From fea222b0b80f0b7162ee83ee0284aa07a77ad0d3 Mon Sep 17 00:00:00 2001 From: Eduardo San Martin Morote Date: Thu, 9 Jun 2022 14:56:24 +0200 Subject: [PATCH] ci: try again --- .github/workflows/test.yml | 9 +++++++++ packages/router/e2e/runner.js | 16 ++++++++-------- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 27299fa6..b763647c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -10,6 +10,10 @@ on: - 'packages/docs/**' - 'packages/playground/**' + env: + BROWSERSTACK_USERNAME: ${{secrets.BROWSERSTACK_USERNAME}} + BROWSERSTACK_ACCESS_KEY: ${{secrets.BROWSERSTACK_ACCESS_KEY}} + jobs: build: runs-on: ubuntu-latest @@ -23,6 +27,11 @@ jobs: with: node-version: '16' cache: 'pnpm' + - name: 'BrowserStack Env Setup' + uses: 'browserstack/github-actions/setup-env@master' + with: + username: ${{ secrets.BROWSERSTACK_USERNAME }} + access-key: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} - run: pnpm install # - run: pnpm run lint diff --git a/packages/router/e2e/runner.js b/packages/router/e2e/runner.js index 616ddb2f..6631a5d6 100644 --- a/packages/router/e2e/runner.js +++ b/packages/router/e2e/runner.js @@ -6,14 +6,6 @@ const path = require('path') console.log('Test', process.env.API_SECRET) const { BROWSERSTACK_ACCESS_KEY } = process.env -if (!BROWSERSTACK_ACCESS_KEY) { - throw new Error( - ` -(ONLY FOR MAINTAINERS) -BROWSERSTACK_ACCESS_KEY is not set. Did you create the .env file? -` - ) -} const args = process.argv.slice(2) @@ -32,6 +24,14 @@ const getServer = const server = await getServer() try { + if (!BROWSERSTACK_ACCESS_KEY) { + throw new Error( + ` +(ONLY FOR MAINTAINERS) +BROWSERSTACK_ACCESS_KEY is not set. Did you create the .env file? +` + ) + } require.main.filename = path.resolve( __dirname, '../../../node_modules/.bin/nightwatch' -- 2.47.2