From ff85ea3f1456f20ba21a67c652f245da6360db15 Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Sat, 26 Jan 2013 22:40:31 +0000 Subject: [PATCH] xfs_fsr: fix attribute no_change_count logic As it stands today, if no_change_count++ isn't > 10, we will reset it to 0. There's no way to get above 1 (let alone 10) so this isn't working as intended. If we see progress (last_forkoff != tbstat.bs_forkoff) *then* we sould reset the no_change_count counter to 0. Signed-off-by: Eric Sandeen Reviewed-by: Mark Tinguely Signed-off-by: Mark Tinguely --- fsr/xfs_fsr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c index b5aa3db76..5eaabb529 100644 --- a/fsr/xfs_fsr.c +++ b/fsr/xfs_fsr.c @@ -1099,8 +1099,8 @@ fsr_setup_attr_fork( if (last_forkoff == tbstat.bs_forkoff) { if (no_change_cnt++ > 10) break; - } - no_change_cnt = 0; + } else /* progress! */ + no_change_cnt = 0; last_forkoff = tbstat.bs_forkoff; /* work out which way to grow the fork */ -- 2.47.2