From 1aa323fc4d131dff3b40ef34117c059d3c885888 Mon Sep 17 00:00:00 2001
From: Otto <otto.moerbeek@open-xchange.com>
Date: Mon, 4 Oct 2021 13:46:59 +0200
Subject: [PATCH] Add two comments based on code review

---
 pdns/recursordist/Makefile.am        | 2 +-
 pdns/recursordist/rec-zonetocache.cc | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/pdns/recursordist/Makefile.am b/pdns/recursordist/Makefile.am
index fe687c6f46..9c157f43c0 100644
--- a/pdns/recursordist/Makefile.am
+++ b/pdns/recursordist/Makefile.am
@@ -315,9 +315,9 @@ testrunner_SOURCES = \
 	test-negcache_cc.cc \
 	test-packetcache_hh.cc \
 	test-rcpgenerator_cc.cc \
+	test-rec-zonetocache.cc \
 	test-recpacketcache_cc.cc \
 	test-recursorcache_cc.cc \
-	test-rec-zonetocache.cc \
 	test-rpzloader_cc.cc \
 	test-secpoll_cc.cc \
 	test-signers.cc \
diff --git a/pdns/recursordist/rec-zonetocache.cc b/pdns/recursordist/rec-zonetocache.cc
index ea614df355..6fdf7568d9 100644
--- a/pdns/recursordist/rec-zonetocache.cc
+++ b/pdns/recursordist/rec-zonetocache.cc
@@ -42,9 +42,14 @@ struct ZoneData
   ZoneData(shared_ptr<Logr::Logger>& log) :
     d_log(log) {}
 
+  // Potentially the two fields below could be merged into a single map. ATM it is not clear to me
+  // if that would make the code easier to read.
   std::map<pair<DNSName, QType>, vector<DNSRecord>> d_all;
   std::map<pair<DNSName, QType>, vector<shared_ptr<RRSIGRecordContent>>> d_sigs;
+
+  // Maybe use a SuffixMatchTree?
   std::set<DNSName> d_delegations;
+
   time_t d_now;
   DNSName d_zone;
   shared_ptr<Logr::Logger>& d_log;
-- 
2.47.2