From 87adc94a97c87452c353fe96b794708b1afb9ec3 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Thu, 7 Oct 2021 14:34:02 +0200 Subject: [PATCH] Rename the 'queued' metric of the Remote Logger to 'processed' Since it was not clear at all whether 'queued' meant 'has been put in the queue at some point, might have been sent or not' or 'actually still in the queue' (it was the former). --- pdns/remote_logger.cc | 2 +- pdns/remote_logger.hh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pdns/remote_logger.cc b/pdns/remote_logger.cc index 736091118f..6e41db647f 100644 --- a/pdns/remote_logger.cc +++ b/pdns/remote_logger.cc @@ -170,7 +170,7 @@ void RemoteLogger::queueData(const std::string& data) } runtime->d_writer.write(data); - ++d_queued; + ++d_processed; } void RemoteLogger::maintenanceThread() diff --git a/pdns/remote_logger.hh b/pdns/remote_logger.hh index c00e882f22..04db3b53ad 100644 --- a/pdns/remote_logger.hh +++ b/pdns/remote_logger.hh @@ -90,7 +90,7 @@ public: void queueData(const std::string& data) override; std::string toString() const override { - return d_remote.toStringWithPort() + " (" + std::to_string(d_queued) + " queued, " + std::to_string(d_drops) + " dropped)"; + return d_remote.toStringWithPort() + " (" + std::to_string(d_processed) + " processed, " + std::to_string(d_drops) + " dropped)"; } void stop() { @@ -109,7 +109,7 @@ private: ComboAddress d_remote; std::atomic d_drops{0}; - std::atomic d_queued{0}; + std::atomic d_processed{0}; uint16_t d_timeout; uint8_t d_reconnectWaitTime; std::atomic d_exiting{false}; -- 2.47.2