From 529fe29fd4064447a3298a02076059cc7ac0596b Mon Sep 17 00:00:00 2001 From: Peter van Dijk Date: Thu, 24 Feb 2022 17:19:21 +0100 Subject: [PATCH] auth lmdb random-ids: stop generating negative numbers regression testing now happens with random IDs, except for HTTP API testing --- ext/lmdb-safe/lmdb-typed.cc | 4 ++-- regression-tests/backends/lmdb-master | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ext/lmdb-safe/lmdb-typed.cc b/ext/lmdb-safe/lmdb-typed.cc index a366da2276..7b0abd339a 100644 --- a/ext/lmdb-safe/lmdb-typed.cc +++ b/ext/lmdb-safe/lmdb-typed.cc @@ -19,9 +19,9 @@ unsigned int MDBGetRandomID(MDBRWTransaction& txn, MDBDbi& dbi) for(int attempts=0; attempts<20; attempts++) { MDBOutVal key, content; - // dns_random generates a random number in [0..type_max-1]. We add 1 to avoid 0 and allow type_max. + // dns_random generates a random number in [0..signed_int_max-1]. We add 1 to avoid 0 and allow type_max. // 0 is avoided because the put() interface uses it to mean "please allocate a number for me" - id = dns_random(std::numeric_limits::max()) + 1; + id = dns_random(std::numeric_limits::max()) + 1; if(cursor.find(MDBInVal(id), key, content)) { return id; } diff --git a/regression-tests/backends/lmdb-master b/regression-tests/backends/lmdb-master index ea0b4aa6a6..77a5dbe3b3 100644 --- a/regression-tests/backends/lmdb-master +++ b/regression-tests/backends/lmdb-master @@ -4,6 +4,7 @@ case $context in module-dir=./modules launch=lmdb lmdb-filename=./pdns.lmdb +lmdb-random-ids=yes __EOF__ rm -f pdns.lmdb* -- 2.47.2