From e59cfbbe9bb4ada299ff27a24deba535213a799d Mon Sep 17 00:00:00 2001 From: Otto Moerbeek Date: Mon, 12 Jun 2023 10:14:03 +0200 Subject: [PATCH] Process review comments --- pdns/recursordist/docs/metrics.rst | 4 ++-- regression-tests.recursor-dnssec/test_SNMP.py | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/pdns/recursordist/docs/metrics.rst b/pdns/recursordist/docs/metrics.rst index 9247a9955c..3700652d9c 100644 --- a/pdns/recursordist/docs/metrics.rst +++ b/pdns/recursordist/docs/metrics.rst @@ -552,12 +552,12 @@ no-packet-error number of erroneous received packets nod-events -^^^^^^^^^ +^^^^^^^^^^ .. versionadded:: 4.9.0 Count of NOD events udr-events -^^^^^^^^^ +^^^^^^^^^^ .. versionadded:: 4.9.0 Count of UDR events diff --git a/regression-tests.recursor-dnssec/test_SNMP.py b/regression-tests.recursor-dnssec/test_SNMP.py index 9a04090ebd..4ad78640cb 100644 --- a/regression-tests.recursor-dnssec/test_SNMP.py +++ b/regression-tests.recursor-dnssec/test_SNMP.py @@ -21,11 +21,15 @@ class TestSNMP(RecursorTest): """ def _checkStatsValues(self, results): - for i in list(range(1, 148)): + count = 148 + for i in list(range(1, count)): oid = self._snmpOID + '.1.' + str(i) + '.0' self.assertTrue(oid in results) self.assertTrue(isinstance(results[oid], Counter64)) + oid = self._snmpOID + '.1.' + str(count + 1) + '.0' + self.assertFalse(oid in results) + # check uptime > 0 self.assertGreater(results['1.3.6.1.4.1.43315.2.1.75.0'], 0) # check memory usage > 0 -- 2.47.2