From d5d26f840ba41b23e2f4c0ba2c359197ff7cd900 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Wed, 23 Aug 2023 17:00:17 +0200 Subject: [PATCH] Change the default for building with net-snmp from `auto` to `no` We have had a fair amount of issues with `net-snmp` adding unexpected and unwanted values to both `CXXFLAGS` and `LDFLAGS`, and it was just reported to also define `HAVE_LIBSSL` is in public header, which messes up our own feature detection. Therefore it is likely better for everyone to prevent net-snmp from being enabled without the user intending it. For our own packages we explicitly enable net-snmp when supported, and this commit also enables it in our CI for dnsdist (it was already done for the recursor) so it should not have any impact. --- m4/pdns_with_net_snmp.m4 | 4 ++-- tasks.py | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/m4/pdns_with_net_snmp.m4 b/m4/pdns_with_net_snmp.m4 index 08ce13987a..19102b6cf1 100644 --- a/m4/pdns_with_net_snmp.m4 +++ b/m4/pdns_with_net_snmp.m4 @@ -1,9 +1,9 @@ AC_DEFUN([PDNS_WITH_NET_SNMP], [ AC_MSG_CHECKING([if we need to link in Net SNMP]) AC_ARG_WITH([net-snmp], - AS_HELP_STRING([--with-net-snmp],[enable net snmp support @<:@default=auto@:>@]), + AS_HELP_STRING([--with-net-snmp],[enable net snmp support @<:@default=no@:>@]), [with_net_snmp=$withval], - [with_net_snmp=auto], + [with_net_snmp=no], ) AC_MSG_RESULT([$with_net_snmp]) diff --git a/tasks.py b/tasks.py index e78e0a5521..6115bd4ed5 100644 --- a/tasks.py +++ b/tasks.py @@ -462,6 +462,7 @@ def ci_dnsdist_configure(c, features): --with-libsodium \ --with-lua=luajit \ --with-libcap \ + --with-net-snmp \ --with-nghttp2 \ --with-re2 ' else: -- 2.47.2