From c16860d87398ab1fb7c37dedf89c2a22b6c4a825 Mon Sep 17 00:00:00 2001
From: Josh Soref <2119212+jsoref@users.noreply.github.com>
Date: Mon, 16 Oct 2023 15:32:58 -0400
Subject: [PATCH] Small refresh to workflow

---
 .../actions/spell-check/candidate.patterns    | 16 +++++++++----
 .github/actions/spell-check/excludes.txt      | 23 ++++++++++++++-----
 .../spell-check/line_forbidden.patterns       |  3 +++
 .github/actions/spell-check/patterns.txt      | 19 ++++++++++-----
 .github/workflows/spelling3.yml               |  6 ++---
 5 files changed, 47 insertions(+), 20 deletions(-)

diff --git a/.github/actions/spell-check/candidate.patterns b/.github/actions/spell-check/candidate.patterns
index bf9dce0b12..7325ad6007 100644
--- a/.github/actions/spell-check/candidate.patterns
+++ b/.github/actions/spell-check/candidate.patterns
@@ -396,7 +396,7 @@ Joaqu[^[:ascii:]]n
 (?:\\(?:u00|x)1[Bb]|\x1b|\\u\{1[Bb]\})\[\d+(?:;\d+|)m
 
 # URL escaped characters
-\%[0-9A-F][A-F]
+\%[0-9A-F][A-F](?=[A-Za-z])
 # lower URL escaped characters
 \%[0-9a-f][a-f](?=[a-z]{2,})
 # IPv6
@@ -496,6 +496,9 @@ content: (['"])[-a-zA-Z=;:/0-9+]*=\g{-1}
 # perl qr regex
 (?<!\$)\bqr(?:\{.*?\}|<.*?>|\(.*?\)|([|!/@#,;']).*?\g{-1})
 
+# perl run
+perl(?:\s+-[a-zA-Z]\w*)+
+
 # Go regular expressions
 regexp?\.MustCompile\(`[^`]*`\)
 
@@ -514,6 +517,9 @@ sed 's/(?:[^/]*?[a-zA-Z]{3,}[^/]*?/){2}
 # go install
 go install(?:\s+[a-z]+\.[-@\w/.]+)+
 
+# jetbrains schema https://youtrack.jetbrains.com/issue/RSRP-489571
+urn:shemas-jetbrains-com
+
 # kubernetes pod status lists
 # https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-phase
 \w+(?:-\w+)+\s+\d+/\d+\s+(?:Running|Pending|Succeeded|Failed|Unknown)\s+
@@ -578,13 +584,13 @@ systemd.*?running in system mode \([-+].*\)$
 # Non-English
 [a-zA-Z]*[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź][a-zA-Z]{3}[a-zA-ZÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź]*|[a-zA-Z]{3,}[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź]|[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź][a-zA-Z]{3,}
 
+# highlighted letters
+\[[A-Z]\][a-z]+
+
 # French
 # This corpus only had capital letters, but you probably want lowercase ones as well.
 \b[LN]'+[a-z]{2,}\b
 
-# latex (check-spelling <= 0.0.21)
-#\\(?:n(?:ew|ormal|osub)|r(?:enew)|t(?:able(?:of|)|he|itle))(?=[a-z]+)
-
 # latex (check-spelling >= 0.0.22)
 \\\w{2,}\{
 
@@ -594,7 +600,7 @@ systemd.*?running in system mode \([-+].*\)$
 # Windows short paths
 [/\\][^/\\]{5,6}~\d{1,2}[/\\]
 
-# in a version of check-spelling after @0.0.21 printf markers won't be automatically consumed
+# in check-spelling@v0.0.22+, printf markers aren't automatically consumed
 # printf markers
 (?<!\\)\\[nrt](?=[a-z]{2,})
 # alternate markers if you run into latex and friends
diff --git a/.github/actions/spell-check/excludes.txt b/.github/actions/spell-check/excludes.txt
index 44460d1033..4cb137b107 100644
--- a/.github/actions/spell-check/excludes.txt
+++ b/.github/actions/spell-check/excludes.txt
@@ -7,9 +7,10 @@
 (?:^|/)go\.mod$
 (?:^|/)go\.sum$
 (?:^|/)m4/
-(?:^|/)m4/
 (?:^|/)package(?:-lock|)\.json$
-(?:^|/)requirements\.(?:txt|in)$
+(?:^|/)Pipfile$
+(?:^|/)pyproject.toml
+(?:^|/)requirements(?:-dev|-doc|-test|)\.txt$
 (?:^|/)vendor/
 /expected_result
 /test-base64_cc\.cc$
@@ -19,11 +20,13 @@ SUMS$
 \.a$
 \.ai$
 \.asc$
+\.all-contributorsrc$
 \.avi$
 \.bmp$
 \.bz2$
 \.cer$
 \.class$
+\.coveragerc$
 \.crl$
 \.crt$
 \.csr$
@@ -35,11 +38,14 @@ SUMS$
 \.eps$
 \.exe$
 \.gif$
+\.git-blame-ignore-revs$
 \.gitattributes$
+\.gitkeep$
 \.graffle$
 \.gz$
 \.icns$
 \.ico$
+\.ipynb$
 \.jar$
 \.jks$
 \.jpe?g$
@@ -49,25 +55,29 @@ SUMS$
 \.map$
 \.min\..
 \.mmdb$
+\.mo$
 \.mod$
-\.mp3$
-\.mp4$
 \.mp[34]$
 \.nsec3(?:-optout|)$
 \.o$
 \.ocf$
 \.otf$
+\.p12$
+\.parquet$
 \.pdf$
 \.pem$
+\.pfx$
 \.png$
 \.psd$
 \.pyc$
+\.pylintrc$
+\.qm$
 \.s$
 \.sig$
 \.so$
 \.supp$
-\.svg$
-\.svgz$
+\.svgz?$
+\.sys$
 \.tar$
 \.tgz$
 \.tiff?$
@@ -79,6 +89,7 @@ SUMS$
 \.xcf$
 \.xlsx?$
 \.xpm$
+\.xz$
 \.yml$
 \.zip$
 ^codedocs/doxygen\.conf$
diff --git a/.github/actions/spell-check/line_forbidden.patterns b/.github/actions/spell-check/line_forbidden.patterns
index df82a713d0..3067a57ca4 100644
--- a/.github/actions/spell-check/line_forbidden.patterns
+++ b/.github/actions/spell-check/line_forbidden.patterns
@@ -11,6 +11,9 @@
 # s.b. anymore
 \bany more[,.]
 
+# s.b. cannot
+\b[Cc]an not\b
+
 # s.b. GitHub
 (?<![&*.]|// |\btype )\bGithub\b(?![{)])
 
diff --git a/.github/actions/spell-check/patterns.txt b/.github/actions/spell-check/patterns.txt
index b372b8b999..25f42486e7 100644
--- a/.github/actions/spell-check/patterns.txt
+++ b/.github/actions/spell-check/patterns.txt
@@ -120,17 +120,24 @@ DoH
 # Questionably acceptable forms of `in to`
 # Personally, I prefer `log into`, but people object
 # https://www.tprteaching.com/log-into-log-in-to-login/
-\b[Ll]og in to\b
+\b(?:[Ll]og|[Ss]ign) in to\b
+
+# to opt in
+\bto opt in\b
 
 # acceptable duplicates
 # ls directory listings
-[-bcdlpsw](?:[-r][-w][-sx]){3}\s+\d+\s+(\S+)\s+\g{-1}\s+\d+\s+
+[-bcdlpsw](?:[-r][-w][-SsTtx]){3}[\.+*]?\s+\d+\s+\S+\s+\S+\s+\d+\s+
+# mount
+\bmount\s+-t\s+(\w+)\s+\g{-1}\b
 # C types and repeated CSS values
-\s(center|div|inherit|long|LONG|none|normal|solid|thin|transparent|very)(?: \g{-1})+\s
+\s(auto|center|div|inherit|long|LONG|none|normal|solid|thin|transparent|very)(?: \g{-1})+\s
+# C struct
+\bstruct\s+(\w+)\s+\g{-1}\b
 # go templates
-\s(\w+)\s+\g{-1}\s+\`(?:graphql|json|yaml):
-# javadoc / .net
-(?:[\\@](?:groupname|param)|(?:public|private)(?:\s+static|\s+readonly)*)\s+(\w+)\s+\g{-1}\s
+\s(\w+)\s+\g{-1}\s+\`(?:graphql|inject|json|yaml):
+# doxygen / javadoc / .net
+(?:[\\@](?:brief|groupname|t?param|return|retval)|(?:public|private|\[Parameter(?:\(.+\)|)\])(?:\s+static|\s+override|\s+readonly)*)(?:\s+\{\w+\}|)\s+(\w+)\s+\g{-1}\s
 
 # Commit message -- Signed-off-by and friends
 ^\s*(?:(?:Based-on-patch|Co-authored|Helped|Mentored|Reported|Reviewed|Signed-off)-by|Thanks-to): (?:[^<]*<[^>]*>|[^<]*)\s*$
diff --git a/.github/workflows/spelling3.yml b/.github/workflows/spelling3.yml
index f09a7ffc19..9df9009ca4 100644
--- a/.github/workflows/spelling3.yml
+++ b/.github/workflows/spelling3.yml
@@ -11,8 +11,6 @@ on:
   pull_request:
     branches:
       - "**"
-    tags-ignore:
-      - "**"
     types:
       - 'opened'
       - 'reopened'
@@ -34,7 +32,7 @@ jobs:
     outputs:
       followup: ${{ steps.spelling.outputs.followup }}
     runs-on: ubuntu-latest
-    if: "contains(github.event_name, 'pull_request') || github.event_name == 'push'"
+    if: ${{ contains(github.event_name, 'pull_request') || github.event_name == 'push' }}
     concurrency:
       group: spelling-${{ github.event.pull_request.number || github.ref }}
       # note: If you use only_check_changed_files, you do not want cancel-in-progress
@@ -45,9 +43,11 @@ jobs:
       uses: check-spelling/check-spelling@v0.0.22
       with:
         config: .github/actions/spell-check
+        suppress_push_for_open_pull_request: ${{ github.actor != 'dependabot[bot]' && 1 }}
         checkout: true
         spell_check_this: powerdns/pdns@master
         post_comment: 0
+        warnings: bad-regex,binary-file,deprecated-feature,ignored-expect-variant,large-file,limited-references,no-newline-at-eof,noisy-file,non-alpha-in-dictionary,token-is-substring,unexpected-line-ending,whitespace-in-dictionary,minified-file,unsupported-configuration,no-files-to-check
         use_sarif: ${{ (!github.event.pull_request || (github.event.pull_request.head.repo.full_name == github.repository)) && 1 }}
         extra_dictionaries:
           cspell:software-terms/dict/softwareTerms.txt
-- 
2.47.2