From 5c9b575fb1f69cfc486606adf775397cfe21f038 Mon Sep 17 00:00:00 2001
From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 16 Nov 2023 12:03:14 +0100
Subject: [PATCH] dnsdist: Clearly document that the current latency bucket is
 UDP only

---
 pdns/dnsdistdist/DNSDIST-MIB.txt     | 12 ++++++------
 pdns/dnsdistdist/docs/statistics.rst | 25 ++++++++++++-------------
 2 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/pdns/dnsdistdist/DNSDIST-MIB.txt b/pdns/dnsdistdist/DNSDIST-MIB.txt
index d6f5a92568..bedf9bc988 100644
--- a/pdns/dnsdistdist/DNSDIST-MIB.txt
+++ b/pdns/dnsdistdist/DNSDIST-MIB.txt
@@ -139,7 +139,7 @@ latency01 OBJECT-TYPE
     MAX-ACCESS read-only
     STATUS current
     DESCRIPTION
-	"Number of queries answered in less than 1 ms"
+	"Number of UDP queries answered in less than 1 ms"
     ::= { stats 14 }
 
 latency110 OBJECT-TYPE
@@ -147,7 +147,7 @@ latency110 OBJECT-TYPE
     MAX-ACCESS read-only
     STATUS current
     DESCRIPTION
-	"Number of queries answered in 1-10 ms"
+	"Number of UDP queries answered in 1-10 ms"
     ::= { stats 15 }
 
 latency1050 OBJECT-TYPE
@@ -155,7 +155,7 @@ latency1050 OBJECT-TYPE
     MAX-ACCESS read-only
     STATUS current
     DESCRIPTION
-	"Number of queries answered in 10-50 ms"
+	"Number of UDP queries answered in 10-50 ms"
     ::= { stats 16 }
 
 latency50100 OBJECT-TYPE
@@ -163,7 +163,7 @@ latency50100 OBJECT-TYPE
     MAX-ACCESS read-only
     STATUS current
     DESCRIPTION
-	"Number of queries answered in 50-100 ms"
+	"Number of UDP queries answered in 50-100 ms"
     ::= { stats 17 }
 
 latency1001000 OBJECT-TYPE
@@ -171,7 +171,7 @@ latency1001000 OBJECT-TYPE
     MAX-ACCESS read-only
     STATUS current
     DESCRIPTION
-	"Number of queries answered in 100-1000 ms"
+	"Number of UDP queries answered in 100-1000 ms"
     ::= { stats 18 }
 
 latencySlow OBJECT-TYPE
@@ -179,7 +179,7 @@ latencySlow OBJECT-TYPE
     MAX-ACCESS read-only
     STATUS current
     DESCRIPTION
-	"Number of queries answered in more than 1s"
+	"Number of UDP queries answered in more than 1s"
     ::= { stats 19 }
 
 latencyAVG100 OBJECT-TYPE
diff --git a/pdns/dnsdistdist/docs/statistics.rst b/pdns/dnsdistdist/docs/statistics.rst
index 664c38df56..1d1c73fc6e 100644
--- a/pdns/dnsdistdist/docs/statistics.rst
+++ b/pdns/dnsdistdist/docs/statistics.rst
@@ -111,23 +111,23 @@ Number of ServFail answers sent to clients.
 
 latency-avg100
 --------------
-Average response latency in microseconds of the last 100 packets
+Average response latency in microseconds of the last 100 packets received over UDP.
 
 latency-avg1000
 ---------------
-Average response latency in microseconds of the last 1000 packets.
+Average response latency in microseconds of the last 1000 packets received over UDP.
 
 latency-avg10000
 ----------------
-Average response latency in microseconds of the last 10000 packets.
+Average response latency in microseconds of the last 10000 packets received over UDP.
 
 latency-avg1000000
 ------------------
-Average response latency in microseconds of the last 1000000 packets.
+Average response latency in microseconds of the last 1000000 packets received over UDP.
 
 latency-bucket
 --------------
-Histogram of response time latencies.
+Histogram of response time latencies for queries received over UDP.
 
 latency-count
 -------------
@@ -183,12 +183,11 @@ Average response latency, in microseconds, of the last 1000000 packets received
 
 latency-slow
 ------------
-Number of queries answered in more than 1 second.
+Number of queries received over UDP answered in more than 1 second.
 
 latency-sum
 -----------
-Total response time of all queries combined in milliseconds since the start of :program:`dnsdist`. Can be used to calculate the
-average response time over all queries.
+Total response time of all queries received over UDP combined in milliseconds since the start of :program:`dnsdist`. Can be used to calculate the average response time over all queries received over UDP.
 
 latency-tcp-avg100
 ------------------
@@ -208,23 +207,23 @@ Average response latency, in microseconds, of the last 1000000 packets received
 
 latency0-1
 ----------
-Number of queries answered in less than 1 ms.
+Number of queries received over UDP answered in less than 1 ms.
 
 latency1-10
 -----------
-Number of queries answered in 1-10 ms.
+Number of queries received over UDP answered in 1-10 ms.
 
 latency10-50
 ------------
-Number of queries answered in 10-50 ms.
+Number of queries received over UDP answered in 10-50 ms.
 
 latency50-100
 -------------
-Number of queries answered in 50-100 ms.
+Number of queries received over UDP answered in 50-100 ms.
 
 latency100-1000
 ---------------
-Number of queries answered in 100-1000 ms.
+Number of queries received over UDP answered in 100-1000 ms.
 
 no-policy
 ---------
-- 
2.47.2