From 22931f35e56ff2c0b5e2147c157a5a765d60b8a2 Mon Sep 17 00:00:00 2001 From: Otto Moerbeek Date: Mon, 8 Apr 2024 13:14:21 +0200 Subject: [PATCH] dnsdist: syslog should be enabled by default Regression introduced with the logging refactoring of dnsdist. In rel/dnsdist-1.8.x: https://github.com/PowerDNS/pdns/blob/4d5bb67a2a75f9d88894e7dfc42bbbebfda297b0/pdns/dnsdist.cc#L103 : bool g_syslog{true}; In master and 1.9.x the newly intrdoduced LoggingConfiguration::s_syslog is inited to false. This does not matter using the default systemd unit file as it disables syslog: ExecStart=@bindir@/dnsdist --supervised --disable-syslog but it does matter for non-systemd cases. --- pdns/dnsdistdist/dolog.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pdns/dnsdistdist/dolog.cc b/pdns/dnsdistdist/dolog.cc index 55a92b8868..ab5c538f94 100644 --- a/pdns/dnsdistdist/dolog.cc +++ b/pdns/dnsdistdist/dolog.cc @@ -32,7 +32,7 @@ std::string LoggingConfiguration::s_structuredLevelPrefix{"prio"}; LoggingConfiguration::TimeFormat LoggingConfiguration::s_structuredTimeFormat{LoggingConfiguration::TimeFormat::Numeric}; bool LoggingConfiguration::s_structuredLogging{false}; bool LoggingConfiguration::s_logTimestamps{false}; -bool LoggingConfiguration::s_syslog{false}; +bool LoggingConfiguration::s_syslog{true}; namespace { -- 2.47.2